Skip to content

Comment out check for ms_tls13kdf tag for FIPS-capable binaries #10148

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 25, 2025
Merged

Comment out check for ms_tls13kdf tag for FIPS-capable binaries #10148

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion dev-tools/packaging/testing/package_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -844,7 +844,13 @@ func checkFIPS(t *testing.T, agentPackageRootDir string) {
case "-tags":
foundTags = true
require.Contains(t, setting.Value, "requirefips")
require.Contains(t, setting.Value, "ms_tls13kdf")
// the check on ms_tls13kdf is no longer needed for go >= 1.25
// It should probably be conditioned to the output of `go version <binary>`
// for example:
// go version elastic-agent-9.2.0-SNAPSHOT-linux-x86_64/data/elastic-agent-7b3817/components/apm-server
// elastic-agent-9.2.0-SNAPSHOT-linux-x86_64/data/elastic-agent-7b3817/components/apm-server: go1.25.1
//
// require.Contains(t, setting.Value, "ms_tls13kdf")
continue
case "GOEXPERIMENT":
foundExperiment = true
Expand Down
Loading