-
Notifications
You must be signed in to change notification settings - Fork 193
[9.0](backport #10103) Update code ownership of core-components.yml #10113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 9.0
Are you sure you want to change the base?
Conversation
* Update code ownership of core-components.yml With increased components' movement, the role of `core-components.yml` is becoming critical. The ingest docs team is not qualified to decide on the content of that file. This PR suggests adding the PM and EM for these file decisions as exclusive owners of the file. That also means they would be gating components updates and changes in each Collector release. * Add group * Update CODEOWNERS (cherry picked from commit 8079da9) # Conflicts: # .github/CODEOWNERS
Cherry-pick of 8079da9 has failed:
To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This backport updates the code ownership of core-components.yml in the CODEOWNERS file to assign it to the @elastic/ingest-otel-leads
team instead of the ingest docs team, reflecting the critical role this file plays in component management decisions for Collector releases.
Key Changes
- Transfers ownership of
core-components.yaml
from docs team to product/engineering leads - Adds several new ownership entries for documentation and sample files
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
<<<<<<< HEAD | ||
/internal/pkg/agent/application/configuration_embed_changed_test.go @elastic/cloudbeat | ||
/internal/pkg/composable/providers/kubernetes @elastic/elastic-agent-control-plane | ||
======= | ||
/.github/workflows/update-docs.yml @elastic/ingest-docs | ||
/docs/reference/edot-collector @elastic/ingest-docs | ||
/docs/scripts/update-docs @elastic/ingest-docs | ||
/internal/pkg/otel/samples @elastic/ingest-otel-data @elastic/ingest-docs | ||
/internal/pkg/otel/core-components.yaml @elastic/ingest-otel-leads | ||
/internal/pkg/composable/providers/kubernetes @elastic/elastic-agent-control-plane | ||
/internal/pkg/otel/samples/darwin/autoops_es.yml @elastic/opex | ||
/internal/pkg/otel/samples/linux/autoops_es.yml @elastic/opex | ||
/internal/pkg/otel/samples/windows/autoops_es.yml @elastic/opex | ||
>>>>>>> 8079da94f (Update code ownership of core-components.yml (#10103)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The file contains unresolved Git merge conflict markers. These conflict markers need to be resolved before the PR can be merged.
<<<<<<< HEAD | |
/internal/pkg/agent/application/configuration_embed_changed_test.go @elastic/cloudbeat | |
/internal/pkg/composable/providers/kubernetes @elastic/elastic-agent-control-plane | |
======= | |
/.github/workflows/update-docs.yml @elastic/ingest-docs | |
/docs/reference/edot-collector @elastic/ingest-docs | |
/docs/scripts/update-docs @elastic/ingest-docs | |
/internal/pkg/otel/samples @elastic/ingest-otel-data @elastic/ingest-docs | |
/internal/pkg/otel/core-components.yaml @elastic/ingest-otel-leads | |
/internal/pkg/composable/providers/kubernetes @elastic/elastic-agent-control-plane | |
/internal/pkg/otel/samples/darwin/autoops_es.yml @elastic/opex | |
/internal/pkg/otel/samples/linux/autoops_es.yml @elastic/opex | |
/internal/pkg/otel/samples/windows/autoops_es.yml @elastic/opex | |
>>>>>>> 8079da94f (Update code ownership of core-components.yml (#10103)) | |
/internal/pkg/agent/application/configuration_embed_changed_test.go @elastic/cloudbeat | |
/internal/pkg/composable/providers/kubernetes @elastic/elastic-agent-control-plane | |
/.github/workflows/update-docs.yml @elastic/ingest-docs | |
/docs/reference/edot-collector @elastic/ingest-docs | |
/docs/scripts/update-docs @elastic/ingest-docs | |
/internal/pkg/otel/samples @elastic/ingest-otel-data @elastic/ingest-docs | |
/internal/pkg/otel/core-components.yaml @elastic/ingest-otel-leads | |
/internal/pkg/otel/samples/darwin/autoops_es.yml @elastic/opex | |
/internal/pkg/otel/samples/linux/autoops_es.yml @elastic/opex | |
/internal/pkg/otel/samples/windows/autoops_es.yml @elastic/opex |
Copilot uses AI. Check for mistakes.
This pull request is now in conflicts. Could you fix it? 🙏
|
This pull request has not been merged yet. Could you please review and merge it @theletterf? 🙏 |
With increased components' movement, the role of
core-components.yml
is becoming critical. The ingest docs team is not qualified to decide on the content of that file.This PR suggests adding the PM and EM for these file decisions as exclusive owners of the file. That also means they would be gating components updates and changes in each Collector release.
Case in point: the status of some new receivers in #9344
+CC @mlunadia @AlexanderWert @colleenmcginnis
This is an automatic backport of pull request #10103 done by [Mergify](https://mergify.com).