[9.2](backport #46313) improve: use SetupMetricsOptions instead of SetupMetrics #46903
+8
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![mergify[bot]](https://avatars.githubusercontent.com/in/10562?s=60&v=4){kind=small}
--------- Co-authored-by: Anderson Queiroz <[email protected]> (cherry picked from commit 2d5086e)
mergify
bot
requested review from
orestisfl and
khushijain21
and removed request for
a team
botelastic
bot
added
the
needs_team
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
github-actions
bot
added
the
Team:Elastic-Agent-Data-Plane
|
Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane) |
botelastic
bot
removed
the
needs_team
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed commit message
The problem is that
SetupMetricsinelastic-agent-system-metricsis conditionally compiled and only available when the build tags(darwin && cgo) || (freebsd && cgo) || linux || windowsare satisfied. If you build on Darwin without cgo, it won't be compiled, hence the undefined symbol.Checklist
CHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.This is an automatic backport of pull request #46313 done by [Mergify](https://mergify.com).