Skip to content

Conversation

mauri870
Copy link
Member

@mauri870 mauri870 commented Sep 9, 2025

Proposed commit message

This commit improves goleak coverage in the receiver tests. By instrumenting oteltest.CheckReceivers, we achieve broader coverage of receiver use cases. It also adds references to the known leaks that are allowed and why.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

How to test this PR locally

go test ./x-pack/filebeat/fbreceiver ./x-pack/metricbeat/mbreceiver -v

Related issues

@mauri870 mauri870 added this to the otel milestone Sep 9, 2025
@mauri870 mauri870 self-assigned this Sep 9, 2025
@mauri870 mauri870 added Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team backport-active-9 Automated backport with mergify to all the active 9.[0-9]+ branches backport-8.19 Automated backport to the 8.19 branch labels Sep 9, 2025
@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Sep 9, 2025
Copy link
Contributor

github-actions bot commented Sep 9, 2025

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • run docs-build : Re-trigger the docs validation. (use unformatted text in the comment!)

@mauri870 mauri870 marked this pull request as ready for review September 9, 2025 11:26
@mauri870 mauri870 requested a review from a team as a code owner September 9, 2025 11:26
@elasticmachine
Copy link
Collaborator

Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane)

@mauri870 mauri870 requested a review from swiatekm September 9, 2025 11:26
Copy link
Member

@AndersonQ AndersonQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the tests pass, it's good

Copy link
Contributor

@swiatekm swiatekm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mauri870 mauri870 enabled auto-merge (squash) September 9, 2025 12:59
@mauri870 mauri870 merged commit cd3537b into elastic:main Sep 9, 2025
207 checks passed
Copy link
Contributor

github-actions bot commented Sep 9, 2025

@Mergifyio backport 9.0 9.1

Copy link
Contributor

mergify bot commented Sep 9, 2025

backport 9.0 9.1

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Sep 9, 2025
* otel: increase goleak coverage in receiver tests

* fix imports

(cherry picked from commit cd3537b)

# Conflicts:
#	x-pack/filebeat/fbreceiver/receiver_test.go
mergify bot pushed a commit that referenced this pull request Sep 9, 2025
* otel: increase goleak coverage in receiver tests

* fix imports

(cherry picked from commit cd3537b)

# Conflicts:
#	x-pack/filebeat/fbreceiver/receiver_leak_test.go
#	x-pack/metricbeat/mbreceiver/receiver_leak_test.go
mergify bot pushed a commit that referenced this pull request Sep 9, 2025
* otel: increase goleak coverage in receiver tests

* fix imports

(cherry picked from commit cd3537b)
mauri870 added a commit that referenced this pull request Sep 9, 2025
* otel: increase goleak coverage in receiver tests

* fix imports

(cherry picked from commit cd3537b)

Co-authored-by: Mauri de Souza Meneguzzo <[email protected]>
mauri870 added a commit that referenced this pull request Sep 9, 2025
…sts (#46471)

* otel: increase goleak coverage in receiver tests (#46466)

* otel: increase goleak coverage in receiver tests

* fix imports

(cherry picked from commit cd3537b)

# Conflicts:
#	x-pack/filebeat/fbreceiver/receiver_test.go

* fix conflicts

---------

Co-authored-by: Mauri de Souza Meneguzzo <[email protected]>
@khushijain21 khushijain21 mentioned this pull request Sep 10, 2025
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-8.19 Automated backport to the 8.19 branch backport-active-9 Automated backport with mergify to all the active 9.[0-9]+ branches Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants