Skip to content

Remove settings on ES exporter config that no longer function #46428

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 17 commits into from
Sep 23, 2025
Merged

Remove settings on ES exporter config that no longer function #46428

merged 17 commits into from
Sep 23, 2025

Conversation

khushijain21
Copy link
Contributor

@khushijain21 khushijain21 commented Sep 8, 2025 •
edited
Loading

Proposed commit message

This PR removes HTTP settings from ES-exporter config that are supported by beatsauthextension instead ref

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Disruptive User Impact

HTTP settings should be configured with beatsauthextension for 1:1 compatibility with beats and beatreceivers

Related issues

@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Sep 8, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 8, 2025

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • run docs-build : Re-trigger the docs validation. (use unformatted text in the comment!)

@mergify Mergify
Copy link
Contributor

mergify bot commented Sep 8, 2025

This pull request does not have a backport label.
If this is a bug or security fix, could you label this PR @khushijain21? 🙏.
For such, you'll need to label your PR with:

  • The upcoming major version of the Elastic Stack
  • The upcoming minor version of the Elastic Stack (if you're not pushing a breaking change)

To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-8./d is the label to automatically backport to the 8./d branch. /d is the digit
  • backport-active-all is the label that automatically backports to all active branches.
  • backport-active-8 is the label that automatically backports to all active minor branches for the 8 major.
  • backport-active-9 is the label that automatically backports to all active minor branches for the 9 major.

@khushijain21 khushijain21 marked this pull request as ready for review September 8, 2025 10:35
@khushijain21 khushijain21 requested a review from a team as a code owner September 8, 2025 10:35
@khushijain21 khushijain21 added the Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team label Sep 8, 2025
@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Sep 8, 2025
@elasticmachine
Copy link
Collaborator

Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane)

@khushijain21 khushijain21 added needs_team Indicates that the issue/PR needs a Team:* label backport-8.19 Automated backport to the 8.19 branch labels Sep 8, 2025
@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Sep 8, 2025
@khushijain21 khushijain21 added needs_team Indicates that the issue/PR needs a Team:* label backport-active-9 Automated backport with mergify to all the active 9.[0-9]+ branches labels Sep 8, 2025
@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Sep 8, 2025
@botelastic
Copy link

botelastic bot commented Sep 8, 2025

This pull request doesn't have a Team:<team> label.

@khushijain21 khushijain21 changed the title Remove settings on ES exporter config that no longer function [DO NOT MERGE] Remove settings on ES exporter config that no longer function Sep 8, 2025
@khushijain21
Copy link
Contributor Author

This should only be merged after elastic/opentelemetry-collector-components#722

@pierrehilbert
Copy link
Collaborator

elastic/opentelemetry-collector-components#722 is now merged

mauri870
mauri870 reviewed Sep 9, 2025
View reviewed changes
cmacknz
cmacknz reviewed Sep 9, 2025
View reviewed changes
@cmacknz cmacknz mentioned this pull request Sep 9, 2025
Merged
6 tasks
@khushijain21 khushijain21 changed the title [DO NOT MERGE] Remove settings on ES exporter config that no longer function Remove settings on ES exporter config that no longer function Sep 10, 2025
@khushijain21 khushijain21 mentioned this pull request Sep 10, 2025
Merged
8 tasks
@khushijain21 khushijain21 requested a review from a team as a code owner September 15, 2025 11:07
@mergify Mergify
Copy link
Contributor

mergify bot commented Sep 18, 2025

This pull request is now in conflicts. Could you fix it? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b removetls upstream/removetls
git merge upstream/main
git push upstream removetls

cmacknz
cmacknz approved these changes Sep 22, 2025
View reviewed changes
Copy link
Member

@cmacknz cmacknz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding pre-emptive approval assuming the comment about marking kerberos auth as unsupported is addressed

@cmacknz cmacknz mentioned this pull request Sep 22, 2025
Merged
6 tasks
@khushijain21 khushijain21 enabled auto-merge (squash) September 23, 2025 04:23
@khushijain21 khushijain21 merged commit d3be9bf into elastic:main Sep 23, 2025
207 checks passed
@github-actions GitHub Actions
Copy link
Contributor

@Mergifyio backport 9.0 9.1

@mergify Mergify
Copy link
Contributor

mergify bot commented Sep 23, 2025 •
edited
Loading

backport 9.0 9.1

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Sep 23, 2025
@khushijain21 @mergify
Remove settings on ES exporter config that no longer function (#46428)
45a0e69 
* Remove settings on ES exporter config that no longer function

(cherry picked from commit d3be9bf)

# Conflicts:
#	go.mod
#	go.sum
#	libbeat/otelbeat/beatconverter/beatconverter.go
#	libbeat/otelbeat/beatconverter/beatconverter_test.go
#	x-pack/filebeat/tests/integration/otel_test.go
#	x-pack/libbeat/common/otelbeat/otel.go
#	x-pack/metricbeat/tests/integration/otel_test.go
@mergify mergify bot mentioned this pull request Sep 23, 2025
Open
6 tasks
mergify bot pushed a commit that referenced this pull request Sep 23, 2025
@khushijain21 @mergify
Remove settings on ES exporter config that no longer function (#46428)
4d43af5 
* Remove settings on ES exporter config that no longer function

(cherry picked from commit d3be9bf)

# Conflicts:
#	go.mod
#	go.sum
#	libbeat/otelbeat/beatconverter/beatconverter.go
#	libbeat/otelbeat/beatconverter/beatconverter_test.go
#	libbeat/otelbeat/oteltranslate/outputs/elasticsearch/config_otel.go
#	libbeat/otelbeat/oteltranslate/outputs/elasticsearch/config_otel_test.go
#	x-pack/filebeat/tests/integration/otel_test.go
#	x-pack/libbeat/common/otelbeat/otel.go
#	x-pack/metricbeat/tests/integration/otel_test.go
@mergify mergify bot mentioned this pull request Sep 23, 2025
Closed
6 tasks
mergify bot pushed a commit that referenced this pull request Sep 23, 2025
@khushijain21 @mergify
Remove settings on ES exporter config that no longer function (#46428)
1fc3930 
* Remove settings on ES exporter config that no longer function

(cherry picked from commit d3be9bf)

# Conflicts:
#	go.mod
#	go.sum
#	libbeat/otelbeat/beatconverter/beatconverter.go
#	libbeat/otelbeat/beatconverter/beatconverter_test.go
#	libbeat/otelbeat/oteltranslate/outputs/elasticsearch/config_otel.go
#	x-pack/libbeat/common/otelbeat/otel.go
@mergify mergify bot mentioned this pull request Sep 23, 2025
Open
6 tasks
@cmacknz cmacknz mentioned this pull request Sep 23, 2025
Merged
This was referenced Sep 24, 2025
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cmacknz cmacknz cmacknz approved these changes

@AndersonQ AndersonQ Awaiting requested review from AndersonQ AndersonQ is a code owner automatically assigned from elastic/elastic-agent-data-plane

@faec faec Awaiting requested review from faec faec is a code owner automatically assigned from elastic/elastic-agent-data-plane

@mauri870 mauri870 Awaiting requested review from mauri870

Assignees

@khushijain21 khushijain21

Labels
backport-8.19 Automated backport to the 8.19 branch backport-active-9 Automated backport with mergify to all the active 9.[0-9]+ branches Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@khushijain21 @elasticmachine @pierrehilbert @cmacknz @mauri870