Skip to content

improve: use SetupMetricsOptions instead of SetupMetrics #46313

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 2, 2025
Merged

improve: use SetupMetricsOptions instead of SetupMetrics #46313

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
2b0ee1d
improve: use SetupMetricsOptions instead of SetupMetrics
nodece Sep 30, 2025
8ab14f7
improve: update EphemeralID usage
nodece Sep 30, 2025
930da56
Fix style
nodece Sep 30, 2025
7525765
Merge branch 'main' into remove-SetupMetrics-usage
AndersonQ Sep 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion libbeat/cmd/instance/beat.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -345,7 +345,14 @@ func (b *Beat) createBeater(bt beat.Creator) (beat.Beater, error) {

reg := b.Monitoring.StatsRegistry().GetOrCreateRegistry("libbeat")

err = metricreport.SetupMetrics(b.Info.Logger.Named("metrics"), b.Info.Beat, version.GetDefaultVersion()) //nolint:staticcheck //keep behavior for now
err = metricreport.SetupMetricsOptions(metricreport.MetricOptions{
Name: b.Info.Beat,
Version: version.GetDefaultVersion(),
EphemeralID: b.Info.ID.String(),
Logger: b.Info.Logger.Named("metrics"),
SystemMetrics: monitoring.Default.GetOrCreateRegistry("system"),
ProcessMetrics: monitoring.Default.GetOrCreateRegistry("beat"),
})
if err != nil {
return nil, err
}
Expand Down