Skip to content

oteltest: fix logger fields added by pipeline telemetry #44286

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 9, 2025

Conversation

mauri870
Copy link
Member

@mauri870 mauri870 commented May 8, 2025

Proposed commit message

These logger fields are added by the OTel collector.

See the proposal at https://github.com/open-telemetry/opentelemetry-collector/blob/main/docs/rfcs/component-universal-telemetry.md#receivers.

While at it, use the newer All iterator function for logs.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Related issues

These logger fields are added by the OTel collector.

- otelcol.component.kind should be lowercase. See open-telemetry/opentelemetry-collector#12865
- otelcol.signal and not signals

See the proposal at https://github.com/open-telemetry/opentelemetry-collector/blob/main/docs/rfcs/component-universal-telemetry.md#receivers.

While at it, use the newer All iterator function for logs.
@mauri870 mauri870 added this to the otel milestone May 8, 2025
@mauri870 mauri870 self-assigned this May 8, 2025
@mauri870 mauri870 requested a review from a team as a code owner May 8, 2025 18:50
@mauri870 mauri870 requested review from faec and khushijain21 May 8, 2025 18:50
@mauri870 mauri870 added Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team backport-9.0 Automated backport to the 9.0 branch backport-8.19 Automated backport to the 8.19 branch labels May 8, 2025
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label May 8, 2025
@elasticmachine
Copy link
Collaborator

Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane)

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label May 8, 2025
@pierrehilbert pierrehilbert requested a review from leehinman May 9, 2025 07:38
@mauri870 mauri870 merged commit f6db7a6 into elastic:main May 9, 2025
195 checks passed
mergify bot pushed a commit that referenced this pull request May 9, 2025
These logger fields are added by the OTel collector.

- otelcol.component.kind should be lowercase. See open-telemetry/opentelemetry-collector#12865
- otelcol.signal and not signals

See the proposal at https://github.com/open-telemetry/opentelemetry-collector/blob/main/docs/rfcs/component-universal-telemetry.md#receivers.

While at it, use the newer All iterator function for logs.

(cherry picked from commit f6db7a6)
mergify bot pushed a commit that referenced this pull request May 9, 2025
These logger fields are added by the OTel collector.

- otelcol.component.kind should be lowercase. See open-telemetry/opentelemetry-collector#12865
- otelcol.signal and not signals

See the proposal at https://github.com/open-telemetry/opentelemetry-collector/blob/main/docs/rfcs/component-universal-telemetry.md#receivers.

While at it, use the newer All iterator function for logs.

(cherry picked from commit f6db7a6)
mauri870 added a commit that referenced this pull request May 12, 2025
)

These logger fields are added by the OTel collector.

- otelcol.component.kind should be lowercase. See open-telemetry/opentelemetry-collector#12865
- otelcol.signal and not signals

See the proposal at https://github.com/open-telemetry/opentelemetry-collector/blob/main/docs/rfcs/component-universal-telemetry.md#receivers.

While at it, use the newer All iterator function for logs.

(cherry picked from commit f6db7a6)

Co-authored-by: Mauri de Souza Meneguzzo <[email protected]>
mauri870 added a commit that referenced this pull request May 12, 2025
)

These logger fields are added by the OTel collector.

- otelcol.component.kind should be lowercase. See open-telemetry/opentelemetry-collector#12865
- otelcol.signal and not signals

See the proposal at https://github.com/open-telemetry/opentelemetry-collector/blob/main/docs/rfcs/component-universal-telemetry.md#receivers.

While at it, use the newer All iterator function for logs.

(cherry picked from commit f6db7a6)

Co-authored-by: Mauri de Souza Meneguzzo <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-8.19 Automated backport to the 8.19 branch backport-9.0 Automated backport to the 9.0 branch cleanup Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants