fix(otel): ensure default processors are applied in fbreceiver #42658
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mauri870
added
Team:Elastic-Agent-Data-Plane
botelastic
bot
added
needs_team
mauri870
force-pushed
the
fbreceiver-default-processors
branch
from
e1456a5 to
c1bb6e1
Compare
|
Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane) |
leehinman
reviewed
Feb 10, 2025
There was a problem hiding this comment.
This definitely fixes the immediate issue.
Longer term though, I'm not sure if we want to always assume that a Beat Receiver will use the default processors.
Maybe change it so that we look at something in the config passed to NewBeatReceiver, and set a field called "UseDefaultProcessors" accordingly in Info. Would need to be before
beats/libbeat/cmd/instance/beat.go
Line 443 in 7514fa9
What do you think?
|
Thanks, makes total sense. I'll make the necessary changes. |
mauri870
force-pushed
the
fbreceiver-default-processors
branch
from
aa7be28 to
061af6b
Compare
mauri870
commented
Feb 13, 2025
|
|
||
| // NewBeatReceiver creates a Beat that will be used in the context of an otel receiver | ||
| func NewBeatReceiver(settings Settings, receiverConfig map[string]interface{}, consumer consumer.Logs, core zapcore.Core) (*Beat, error) { | ||
| func NewBeatReceiver(settings Settings, receiverConfig map[string]interface{}, useDefaultProcessors bool, consumer consumer.Logs, core zapcore.Core) (*Beat, error) { |
There was a problem hiding this comment.
Having the option inside receiverConfig is also possible, but it only contains the Beats configuration, so I'd have to remove the key from the map. Being explicit here seems more appropriate.
mergify bot
pushed a commit
that referenced
this pull request
Feb 14, 2025
* fix(otel): ensure default processors are applied in fbreceiver * set default processors in NewBeatReceiver (cherry picked from commit d813311)
mergify bot
pushed a commit
that referenced
this pull request
Feb 14, 2025
* fix(otel): ensure default processors are applied in fbreceiver * set default processors in NewBeatReceiver (cherry picked from commit d813311)
This was referenced Feb 14, 2025
mauri870
added a commit
that referenced
this pull request
Feb 14, 2025
… (#42713) * fix(otel): ensure default processors are applied in fbreceiver * set default processors in NewBeatReceiver (cherry picked from commit d813311) Co-authored-by: Mauri de Souza Meneguzzo <[email protected]>
mauri870
added a commit
that referenced
this pull request
Feb 14, 2025
… (#42712) * fix(otel): ensure default processors are applied in fbreceiver * set default processors in NewBeatReceiver (cherry picked from commit d813311) Co-authored-by: Mauri de Souza Meneguzzo <[email protected]>
This was referenced Feb 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed commit message
Currently default processors are only applied under fleet management. Enable default processors for beats when running under OTel receiver mode.
Checklist
CHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.Related issues