Skip to content

[Heartbeat]: use node version 18 for HB images #34469

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
vigneshshanmugam merged 2 commits into from
Feb 24, 2023
Merged

[Heartbeat]: use node version 18 for HB images #34469

vigneshshanmugam merged 2 commits into from
Feb 24, 2023

Conversation

@vigneshshanmugam
Copy link
Member

@vigneshshanmugam vigneshshanmugam commented Feb 2, 2023

What does this PR do?

Missed change from backport #32122

Use the recommended Node.js version 18.12.0 for HB images for running Synthetic monitors.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

@vigneshshanmugam vigneshshanmugam requested a review from a team as a code owner February 2, 2023 19:58
@vigneshshanmugam vigneshshanmugam requested review from belimawr and leehinman and removed request for a team February 2, 2023 19:58
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Feb 2, 2023
@vigneshshanmugam vigneshshanmugam added 7.17-candidate Team:obs-ds-hosted-services Label for the Observability Hosted Services team labels Feb 2, 2023
@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Feb 2, 2023
@elasticmachine
Copy link
Contributor

elasticmachine commented Feb 2, 2023

Pinging @elastic/uptime (Team:Uptime)

@vigneshshanmugam vigneshshanmugam added Heartbeat needs_team Indicates that the issue/PR needs a Team:* label labels Feb 2, 2023
@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Feb 2, 2023
@vigneshshanmugam vigneshshanmugam added bug needs_team Indicates that the issue/PR needs a Team:* label labels Feb 2, 2023
@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Feb 2, 2023
@vigneshshanmugam vigneshshanmugam requested a review from a team February 2, 2023 19:58
@elasticmachine
Copy link
Contributor

elasticmachine commented Feb 2, 2023 •
edited by jenkins-beats-ci bot
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-02-24T10:10:25.834+0000

  • Duration: 133 min 54 sec

❕ Flaky test report

No test was executed to be analysed.

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages and run the E2E tests.

  • /beats-tester : Run the installation tests with beats-tester.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

emilioalvap
emilioalvap reviewed Feb 2, 2023
View reviewed changes
emilioalvap
emilioalvap approved these changes Feb 2, 2023
View reviewed changes
Copy link
Contributor

@emilioalvap emilioalvap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vigneshshanmugam
Copy link
Member Author

vigneshshanmugam commented Feb 7, 2023

/test

@vigneshshanmugam @emilioalvap
[Heartbeat]: use node version 18 for HB images
64768f9 
add changelog

remove duplicate env variable

Co-authored-by: Emilio Alvarez Piñeiro <[email protected]>
@emilioalvap
Copy link
Contributor

emilioalvap commented Feb 24, 2023

/test

@vigneshshanmugam vigneshshanmugam merged commit bf388ae into elastic:7.17 Feb 24, 2023
@vigneshshanmugam vigneshshanmugam deleted the hb-node-version branch February 24, 2023 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@andrewvc andrewvc andrewvc approved these changes

@emilioalvap emilioalvap emilioalvap approved these changes

@belimawr belimawr Awaiting requested review from belimawr belimawr is a code owner automatically assigned from elastic/elastic-agent-data-plane

@leehinman leehinman Awaiting requested review from leehinman leehinman is a code owner automatically assigned from elastic/elastic-agent-data-plane

Assignees

@vigneshshanmugam vigneshshanmugam

Labels

7.17-candidate bug Heartbeat Team:obs-ds-hosted-services Label for the Observability Hosted Services team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@vigneshshanmugam @elasticmachine @emilioalvap @andrewvc