chore: clarify the latest major version of the instrumentation module for some instrumentations #4837
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… for some instrumentations In docs, instrumentation, and tests, the major version of the target module being instrumented was not specified. There should be no functional change for any current releases of modules with this change. In other words, any changes to actual instrumentations is capping the major version supported at the *currently released* major version. Closes: #4803
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
🔍 Preview links for changed docs |
trentm
commented
Oct 28, 2025
| versions: '>=8.0.0' | ||
| versions: | ||
| mode: max-5 | ||
| include: '>=8.0.0 <17' |
Member
Author
There was a problem hiding this comment.
This change massively reduces the number of versions tested:
% TAV=elasticsearch npx tav --dry-run --verbose | rg matching
-- 54 package versions matching filter: 8.0.1, 8.1.0, 8.2.0, 9.0.0, 9.0.1, 9.0.2, 10.0.0, 10.0.1, 10.1.0, 10.1.1, 10.1.2, 10.1.3, 11.0.0, 11.0.1, 12.0.0, 12.0.1, 12.1.0, 12.1.1, 12.1.2, 12.1.3, 13.0.0, 13.0.1, 13.1.0, 13.1.1, 13.1.2, 13.2.0, 13.3.0, 13.3.1, 14.0.0, 14.1.0, 14.2.0, 14.2.1, 14.2.2, 15.0.0, 15.1.0, 15.1.1, 15.2.0, 15.3.0, 15.3.1, 15.4.0, 15.4.1, 15.5.0, 16.0.0, 16.1.0, 16.1.1, 16.2.0, 16.3.0, 16.4.0, 16.5.0, 16.6.0, 16.7.0, 16.7.1, 16.7.2, 16.7.3
[16:04:13 trentm@peach:~/el/apm-agent-nodejs6 (git:trentm-cap-major-ver-for-instrs)]
% TAV=elasticsearch npx tav --dry-run --verbose | rg matching
-- 5 package versions matching filter: 8.0.1, 12.1.0, 15.0.0, 16.7.1, 16.7.3
Member
There was a problem hiding this comment.
We skip some major releases but I think we're fine.
david-luna
approved these changes
Oct 29, 2025
| versions: '>=8.0.0' | ||
| versions: | ||
| mode: max-5 | ||
| include: '>=8.0.0 <17' |
Member
There was a problem hiding this comment.
We skip some major releases but I think we're fine.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In docs, instrumentation, and tests, the major version of the target
module being instrumented was not specified. There should be no functional
change for any current releases of modules with this change. In other
words, any changes to actual instrumentations is capping the major version
supported at the currently released major version.
Closes: #4803