Skip to content

Conversation

@xaota
Copy link

@xaota xaota commented Apr 5, 2024

No description provided.

Copy link
Member

@igorkamyshev igorkamyshev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution 🙏

  1. Please add changeset by instruction in README. It will be used to determine the next version of the library and would be filled to CHANGELOG.
  2. Please mark your changes in docs. At least in API ref with a mention that this overload is available since the next minor release (0.13 I assume).
  3. I see runtime-tests for the change, but I do not see any type-test. Could you add it to ensure your changes are working correctly with TS?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants