ci: fix check-new-packages workflow and checkPublish script #16650
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Follow up of GH-16630 - fix checkout step and make sure to fetch master branch for comparison - fix commentBody to use backticks to have a proper multi-line string in JavaScript
add an example issue link for the initial manual publish run for new theia packages
The checkPublish script did not work properly for next releases, if a new package was freshly released. This change updates the checkPublish script to check for next releases if all packages (also new ones) were published to npm.
ndoschek
changed the title
ndoschek
changed the title
github-project-automation
bot
moved this from Waiting on reviewers
to Needs merge
in PR Backlog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
Follow up of GH-16630
How to test
npm run publish:check next- should be successful as all current packages have been published to npm as nextnpm run publish:check- should fail, as there is a new package that was not published yet as 1.66.0 (the current version of the package.json files is used for the comparison. For a minor or patch release for example, the version in the package.json files is also updated, and then this check also is correct).Follow-ups
Breaking changes
Attribution
Review checklist
nlsservice (for details, please see the Internationalization/Localization section in the Coding Guidelines)Reminder for reviewers