-
Notifications
You must be signed in to change notification settings - Fork 2.8k
ci: update publish-release workflow for release automation #16433
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Resolves GH-16314 - add is_patch_to_previous input to support patching previous release branches, with input validation - clarify release_type input documentation - fetch full git history to support accurate versioning - split publish steps: separate steps for latest and previous patch publishing - replace pull request creation with direct commit/push using bot account Contributed on behalf of STMicroelectronics
|
Hi @jfaltermeier, |
| commit-message: Package update for version ${{ env.NEXT_VERSION_NUMBER }} | ||
| body: Automated package update for Theia version ${{ env.NEXT_VERSION_NUMBER }}. Triggered by @${{ github.actor }}. | ||
| NPM_CONFIG_PROVENANCE: "true" | ||
| NODE_AUTH_TOKEN: ${{ secrets.NPM_AUTH_TOKEN }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As of yesterday, npm changed their auth token policy. Instead of rotating the tokens every 90 days (which is very annoying, since we always need to create a helpdesk issue for that), shouldn't we just enable this repo as an OIDC token provider?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, I totally agree! As discussed in today's dev meeting, I've created a follow up: #16434
|
Hi @ndoschek, first of all this looks very good and I believe it should work. Regarding the commit vs PR approach: Using I understand that we will have to force-push some more changes anyway, but the first commit With a PR, the ECA validation would at least downvote if anything is wrong. I don’t know if it would also be possible to sign an ECA for a bot user, which might be the nicest solution. |
|
Thanks @jfaltermeier, I hadn't considered the ECA validation, but that makes total sense and as we use a similar flow for ide-snap publishing I think this is a good solution! I've updated the workflow to create a PR again. I also did another test run for the workflow, and the resulting PR looks good from my point of view. This should already help streamline the release process a bit, and now we have NPM provenance enabled as well. Here’s the test run and the corresponding PR:
|
jfaltermeier
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, LGTM

What it does
Resolves GH-16314
Contributed on behalf of STMicroelectronics
Some notes:
How to test
Follow-ups
x
Breaking changes
Attribution
Contributed on behalf of STMicroelectronics
Review checklist
Reminder for reviewers