flatpak: Allow generating the Flatpak bundle #617
Conversation
|
Hey @livingsilver94, thank you for your contribution! Could you please sign the Eclipse ECA and sign your commits with the mail you signed the ECA, so we can take a look at the PR? |
|
Yes, I'm trying to. I think I've signed the ECA even though the autocheck isn't reporting that. Guess I'm clumsy w.r.t. bureaucracy. I'll get through it. |
livingsilver94
force-pushed
the
flatpak
branch
from
2cca4cd to
013690e
Compare
|
I don't know what's going on here.
Yet the autocheck says I haven't signed the ECA, even after I pressed "revalidate". |
|
It worked now. I did absolutely nothing. It seems it just took some time. |
| <display_length compare="ge">768</display_length> | ||
| </requires> | ||
|
|
||
| <url type="bugtracker">https://github.com/eclipse-theia/theia-ide/issues</url> |
There was a problem hiding this comment.
Do you prefer theia-ide or theia?
There was a problem hiding this comment.
I'd rather use the .desktop file the regular build process is creating, but AFAIU it's generated programmatically. If you could create a template file of the .desktop entry, then we can de-duplicate the effort.
This PR allows to generate a Flatpak bundle of theia-ide. This PR does not publish Theia on Flathub. Publishing applications to Flathub requires a process in which building the Flatpak bundle is only one of the steps. Signed-off-by: Fabio Forni <[email protected]>
livingsilver94
force-pushed
the
flatpak
branch
from
013690e to
f89cbb9
Compare
|
I've rebased my PR against master. |
|
Just a update: We are currently investigating internally, what the best way to handle this in our release workflow is and where we want this merged. We are very thankful for your Contributions and i tested it and it works great 👍 So Thank you! We will get back to you if we have more details! |
2 participants
What it does
This PR allows to generate a Flatpak bundle of theia-ide.
This PR does not publish Theia on Flathub. Publishing applications to Flathub requires a process in which building the Flatpak bundle is only one of the steps. I'll try to take care of it later.
This PR is related to #360, although it doesn't entirely solve it because:
How to test
You should follow the Readme. After that, to run Theia, either run it from the application menu of your desktop environment or launch
flatpak run org.eclipse.theia.At any rate, here is the convenient command to both build and install Theia:
flatpak-builder flatpak/build flatpak/org.eclipse.theia.yaml --install-deps-from=flathub --force-clean --user --install(note the--installflag).Review checklist
Reminder for reviewers