feat: improve handling of default values for ValueInjectionPoints #4620
+102
−47
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paullatzelsperger
requested review from
jimmarino and
ndr-brt
as code owners
7 tasks
jimmarino
approved these changes
Nov 13, 2024
wolf4ood
approved these changes
Nov 13, 2024
ndr-brt
approved these changes
Nov 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR changes/adds
this PR improves the handling of default values for
ValueInjectionPoints.Specifically, the
ValueInjectionPointnow has a defaultValueProvider, which reads the default value from the annotation attribute.Why it does that
re-use existing infrastructure
Further notes
the
ServiceProviderclass now implements theValueProviderinterface and is a specific variant forServiceInjectionPointsLinked Issue(s)
Contributes to #4610
Please be sure to take a look at the contributing guidelines and our etiquette for pull requests.