-
Notifications
You must be signed in to change notification settings - Fork 9
Open
Description
These are the things I feel like shouting at people. The things that get done for the first couple of weeks and then fall by the wayside and that can't happen. The things I remind people to do over and over again but seem to only be done to varying degrees and by a handful of people:
- Create an issue before you start working on anything
- Discuss your proposed implementation in that issue
- Add a time estimate to it
- Once there is at least one comment agreeing the feature is needed, start working on it _by adding to the readme _first**
- Link all commits to a relevant issue
- Each PR should:
- Solve only one problem: fix one bug, implement one small feature or part thereof
- Have a clear and simple description which also links to the issue it solves
- Add to the documentation or explain why it shouldn't
- Include full tests for any code that is introduced
- Be assigned to the designated QA when ready for review
Adds to #12
nelsonic and rebeccaradding