Create embeddable entity for storing common file information #690
Conversation
Koc
changed the title
|
@garak ready |
Entity/File.php
Outdated
| */ | ||
| protected $size; | ||
|
|
||
| public function getName() |
There was a problem hiding this comment.
What about some phpdoc here? And on other methods, too
There was a problem hiding this comment.
I can add phpdocs with param/return types, but I haven't see any profit from method descriptions like Sets the original file name. It clear from method name what it do :)
There was a problem hiding this comment.
So, I push it further: what about type-hinting setters? With default null values, of course
There was a problem hiding this comment.
Anyway, I wasn't suggesting to add descriptions, just @param and @return
Entity/File.php
Outdated
| */ | ||
| protected $size; | ||
|
|
||
| public function getName() |
There was a problem hiding this comment.
So, I push it further: what about type-hinting setters? With default null values, of course
Entity/File.php
Outdated
| */ | ||
| protected $size; | ||
|
|
||
| public function getName() |
There was a problem hiding this comment.
Anyway, I wasn't suggesting to add descriptions, just @param and @return
|
@garak yes, I'l do it later when other codebase will be moved to scalar type hints. Currently we are using this bundle on php 5.5.9 🤣 |
Another one small step to reduce boilerplate when using the bundle.
TODO: