-
Notifications
You must be signed in to change notification settings - Fork 519
Set default upload destination #1527
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Docs need update
Hi, |
The option can't be removed, it's still valid. The explanation is needed though |
After PR #1529, the |
With a proper injection |
Done! |
docs/usage.md
Outdated
@@ -41,6 +41,10 @@ vich_uploader: | |||
This is the minimal amount of configuration needed in order to describe a | |||
working mapping. | |||
|
|||
> [!NOTE] | |||
> If the `upload_destination` parameter is missing, it this concatenated with |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"it this concatenated" doesn't make sense
@@ -200,6 +201,19 @@ protected function fixDbDriverConfig(array $config): array | |||
return $config; | |||
} | |||
|
|||
protected function fixUploadDestinationConfig(ContainerBuilder $container, array $config): array | |||
{ | |||
// mapping with no declared upload_destination use the uri_prefix |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"use" -> "uses"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's the same as comment in fixDbDriverConfig()
function. We must also update?
docs/usage.md
Outdated
@@ -41,6 +41,10 @@ vich_uploader: | |||
This is the minimal amount of configuration needed in order to describe a | |||
working mapping. | |||
|
|||
> [!NOTE] | |||
> If the `upload_destination` parameter is missing, it this set automatically |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not much better than before. Don't you have a spell checker?
Any chance to create a new version ? |
As soon as we solve 1531 |
OK. Thank You. |
Fix #1526