Skip to content

Add support for text protocol #326

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

HuyNguyen7994
Copy link

Continue from this #325 . Some issues so I have to recreate the repo.
Change from that PR:

  • Collect all values in a single column then cast
  • Try to add tests for simple primitive types

I tried setting pg_use_legacy_text_protocol=true as default and tests just failed all over the place. Issues mostly involve:

  • Complex, nested data type like ARRAY, LIST, ENUM
  • Non SELECT statement like DELETE. I tried and failed to handle ctid data type
  • count(*) also have problems. Somehow it skips querying the ctid and just get all columns normally

At this point I just hit the wall with my C++ level. I will try to make it work with more statements, but not gonna try with any complex type. Probably better to keep those unsupported types as text but I'm torn between making this behavior implicit by default, or introducing new setting to make it explicit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant