Add support for text protocol #326
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continue from this #325 . Some issues so I have to recreate the repo.
Change from that PR:
I tried setting
pg_use_legacy_text_protocol=true
as default and tests just failed all over the place. Issues mostly involve:At this point I just hit the wall with my C++ level. I will try to make it work with more statements, but not gonna try with any complex type. Probably better to keep those unsupported types as text but I'm torn between making this behavior implicit by default, or introducing new setting to make it explicit.