Fix tests for RadarRotatingElevationBearingRange sensor #1151
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
csherman-dstl
requested review from
hpritchett-dstl and
timothy-glover
and removed request for
a team
jswright-dstl
approved these changes
Apr 1, 2025
csherman-dstl
force-pushed
the
fix-rotating-ebr-tests
branch
from
9e50a28 to
379d0c0
Compare
timothy-glover
approved these changes
Apr 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Positions of targets in the Rotating EBR sensor test were placed in the wrong position previously and so the tests only passed due to the sensor's FOV not being small enough.
Targets have been moved to the correct positions and the FOV's have been reduced.
The argument
valuehas been added to the abstractmethod ofaction_from_valuein theRealNumberActionGenerator.