-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Nagilson nagilson cplt wrkfl #52115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Nagilson nagilson cplt wrkfl #52115
Conversation
Co-authored-by: nagilson <[email protected]>
Co-authored-by: nagilson <[email protected]>
Co-authored-by: nagilson <[email protected]>
Co-authored-by: nagilson <[email protected]>
Co-authored-by: nagilson <[email protected]>
Co-authored-by: nagilson <[email protected]>
Co-authored-by: nagilson <[email protected]>
|
/update-xlf |
|
/updatexlf |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This pull request introduces automated GitHub Actions workflows to streamline developer maintenance tasks. The PR adds two comment-triggered workflows (/updatexlf and /fixcompletions) that automatically update translation files and CLI completion snapshots directly in pull requests, eliminating the need for local builds. Documentation is updated across three files to explain these new features to developers.
Key Changes:
- Added two GitHub Actions workflows triggered by PR comments for automated maintenance tasks
- Updated documentation to describe the new automated workflows and how to use them
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
.github/workflows/update-xlf-on-comment.yml |
New workflow that responds to /updatexlf comments to automatically run UpdateXlf target and commit translation file updates |
.github/workflows/fix-completions-on-comment.yml |
New workflow that responds to /fixcompletions comments to automatically update CLI completion snapshot files |
documentation/project-docs/snapshot-based-testing.md |
Added section documenting the /fixcompletions automated workflow feature |
documentation/project-docs/developer-guide.md |
Added "Automated PR Maintenance Commands" section documenting both /updatexlf and /fixcompletions workflows |
documentation/project-docs/Localization.md |
Added section documenting the /updatexlf automated workflow feature |
| id: compare | ||
| if: steps.test.outcome != 'skipped' | ||
| run: | | ||
| dotnet restore test/dotnet.Tests/ /t:CompareCliSnapshots |
Copilot
AI
Dec 10, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The command dotnet restore test/dotnet.Tests/ /t:CompareCliSnapshots is incorrect. The dotnet restore command does not support MSBuild target execution via /t:. This should be changed to dotnet build test/dotnet.Tests/dotnet.Tests.csproj /t:CompareCliSnapshots or dotnet msbuild test/dotnet.Tests/dotnet.Tests.csproj /t:CompareCliSnapshots to properly invoke the MSBuild target.
| dotnet restore test/dotnet.Tests/ /t:CompareCliSnapshots | |
| dotnet build test/dotnet.Tests/dotnet.Tests.csproj /t:CompareCliSnapshots |
| if: steps.check-changes.outputs.changes == 'true' | ||
| run: | | ||
| # This renames .received.* files to .verified.* | ||
| dotnet restore test/dotnet.Tests/ /t:UpdateCliSnapshots |
Copilot
AI
Dec 10, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The command dotnet restore test/dotnet.Tests/ /t:UpdateCliSnapshots is incorrect. The dotnet restore command does not support MSBuild target execution via /t:. This should be changed to dotnet build test/dotnet.Tests/dotnet.Tests.csproj /t:UpdateCliSnapshots or dotnet msbuild test/dotnet.Tests/dotnet.Tests.csproj /t:UpdateCliSnapshots to properly invoke the MSBuild target.
No description provided.