Skip to content

Conversation

@nagilson
Copy link
Member

No description provided.

Copilot AI review requested due to automatic review settings December 10, 2025 18:32
@nagilson
Copy link
Member Author

/update-xlf

@nagilson
Copy link
Member Author

/updatexlf

@nagilson nagilson closed this Dec 10, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request introduces automated GitHub Actions workflows to streamline developer maintenance tasks. The PR adds two comment-triggered workflows (/updatexlf and /fixcompletions) that automatically update translation files and CLI completion snapshots directly in pull requests, eliminating the need for local builds. Documentation is updated across three files to explain these new features to developers.

Key Changes:

  • Added two GitHub Actions workflows triggered by PR comments for automated maintenance tasks
  • Updated documentation to describe the new automated workflows and how to use them

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
.github/workflows/update-xlf-on-comment.yml New workflow that responds to /updatexlf comments to automatically run UpdateXlf target and commit translation file updates
.github/workflows/fix-completions-on-comment.yml New workflow that responds to /fixcompletions comments to automatically update CLI completion snapshot files
documentation/project-docs/snapshot-based-testing.md Added section documenting the /fixcompletions automated workflow feature
documentation/project-docs/developer-guide.md Added "Automated PR Maintenance Commands" section documenting both /updatexlf and /fixcompletions workflows
documentation/project-docs/Localization.md Added section documenting the /updatexlf automated workflow feature

id: compare
if: steps.test.outcome != 'skipped'
run: |
dotnet restore test/dotnet.Tests/ /t:CompareCliSnapshots
Copy link

Copilot AI Dec 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The command dotnet restore test/dotnet.Tests/ /t:CompareCliSnapshots is incorrect. The dotnet restore command does not support MSBuild target execution via /t:. This should be changed to dotnet build test/dotnet.Tests/dotnet.Tests.csproj /t:CompareCliSnapshots or dotnet msbuild test/dotnet.Tests/dotnet.Tests.csproj /t:CompareCliSnapshots to properly invoke the MSBuild target.

Suggested change
dotnet restore test/dotnet.Tests/ /t:CompareCliSnapshots
dotnet build test/dotnet.Tests/dotnet.Tests.csproj /t:CompareCliSnapshots

Copilot uses AI. Check for mistakes.
if: steps.check-changes.outputs.changes == 'true'
run: |
# This renames .received.* files to .verified.*
dotnet restore test/dotnet.Tests/ /t:UpdateCliSnapshots
Copy link

Copilot AI Dec 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The command dotnet restore test/dotnet.Tests/ /t:UpdateCliSnapshots is incorrect. The dotnet restore command does not support MSBuild target execution via /t:. This should be changed to dotnet build test/dotnet.Tests/dotnet.Tests.csproj /t:UpdateCliSnapshots or dotnet msbuild test/dotnet.Tests/dotnet.Tests.csproj /t:UpdateCliSnapshots to properly invoke the MSBuild target.

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant