Improve target graph handling in log messages #50694
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR is targeting |
…es to contain both a framework and an alias
nkolev92
force-pushed
the
dev-nkolev92-improveTargetGraphHandling
branch
from
fddfc22 to
d3865fe
Compare
dsplaisted
approved these changes
Sep 10, 2025
zivkan
approved these changes
Sep 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With target framework aliasing, NuGet will change the target graph name within the log message from tfm/rid to alias/rid.
Since the NuGet & SDK version combinations will vary in the wild due to global.json and VS shipping it's own version of NuGet, the SDK will be need to be able to handle both iterations.
Long term, NuGet will only use the aliasing, so the implementation will have better perf with aliasing.
By getting this change in in 10.0, it will allow more seamless round tripping and allow to minimize the potential for bugs by rolling out the changes in smaller chunks instead of one mega switch.
Progress towards: NuGet/Home#14528