Spike of generated COM interop and LibraryImports #49669
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joeloff
reviewed
Jul 7, 2025
| #if NET | ||
| [LibraryImport("kernel32.dll", StringMarshalling = StringMarshalling.Utf16, SetLastError = true)] | ||
| #else | ||
| [DllImport("kernel32.dll", CharSet = CharSet.Unicode, SetLastError = true)] |
Member
There was a problem hiding this comment.
Can probably add [DefaultDllImportSearchPaths(DllImportSearchPath.System32)] to anything from OS.
Member
Author
There was a problem hiding this comment.
I don't actually know if that attribute works with the generated stuff? It'd be good to learn more.
Contributor
There was a problem hiding this comment.
It works, but kernel32.dll should be in the Known DLLs list, and specifying a default search path is not necessary.
59 tasks
Comment on lines
+16
to
+19
| #if NET9_0_OR_GREATER | ||
| [assembly: System.Runtime.CompilerServices.DisableRuntimeMarshalling] | ||
| #endif | ||
|
|
Contributor
There was a problem hiding this comment.
Remove and set <DisableRuntimeMarshalling>true</DisableRuntimeMarshalling> in the project?
Suggested change
| #if NET9_0_OR_GREATER | |
| [assembly: System.Runtime.CompilerServices.DisableRuntimeMarshalling] | |
| #endif |
Member
Author
|
Closing in favor of something @JeremyKuhne is going to send very soon. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #49667 - specifically an exploration of what using the generated COM and LibraryInterop wrappers might look like