Delete redundant RhpUniversalTransition #122689
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Left-over from .NET Native calling convention converter. We only need the tailcall variant of universal transition.
Member
Author
|
Related to #122639 |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes the redundant RhpUniversalTransition function that was a leftover from the .NET Native calling convention converter. Only the tailcall variant is retained, which is the only one actually needed.
Key Changes
- Renamed
RhpUniversalTransition_DebugStepTailCalltoRhpUniversalTransitionTailCallacross all architectures - Removed the non-tailcall
RhpUniversalTransitionvariant and associated debugger step-in/step-over comments - Removed
FEATURE_DYNAMIC_CODEandFEATURE_CUSTOM_IMPORTSpreprocessor conditionals and definitions
Reviewed changes
Copilot reviewed 19 out of 19 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/coreclr/runtime/riscv64/StubDispatch.S | Updated external reference and call to use renamed RhpUniversalTransitionTailCall |
| src/coreclr/runtime/loongarch64/StubDispatch.S | Updated external reference and branch to use renamed RhpUniversalTransitionTailCall |
| src/coreclr/runtime/i386/StubDispatch.asm | Updated external reference and jump to use renamed RhpUniversalTransitionTailCall |
| src/coreclr/runtime/arm/StubDispatch.S | Updated branch to use renamed RhpUniversalTransitionTailCall |
| src/coreclr/nativeaot/Runtime/riscv64/UniversalTransition.S | Removed UniversalTransition and UniversalTransition_DebugStepTailCall variants, kept only UniversalTransitionTailCall |
| src/coreclr/nativeaot/Runtime/portable.cpp | Updated return location variables to use new UniversalTransitionTailCall naming |
| src/coreclr/nativeaot/Runtime/loongarch64/UniversalTransition.S | Removed redundant variants, kept only UniversalTransitionTailCall |
| src/coreclr/nativeaot/Runtime/i386/UniversalTransition.asm | Removed FEATURE_DYNAMIC_CODE conditional and redundant variants, kept only UniversalTransitionTailCall |
| src/coreclr/nativeaot/Runtime/arm64/UniversalTransition.asm | Removed redundant variants and debugger step-in/step-over comments, kept only UniversalTransitionTailCall |
| src/coreclr/nativeaot/Runtime/arm64/UniversalTransition.S | Removed redundant variants and debugger step-in/step-over comments, kept only UniversalTransitionTailCall |
| src/coreclr/nativeaot/Runtime/arm64/CachedInterfaceDispatchAot.asm | Updated external reference and branch to use renamed RhpUniversalTransitionTailCall |
| src/coreclr/nativeaot/Runtime/arm64/CachedInterfaceDispatchAot.S | Updated external reference and branch to use renamed RhpUniversalTransitionTailCall |
| src/coreclr/nativeaot/Runtime/arm/UniversalTransition.S | Removed FEATURE_DYNAMIC_CODE conditional and redundant variants, kept only UniversalTransitionTailCall |
| src/coreclr/nativeaot/Runtime/amd64/UniversalTransition.asm | Removed FEATURE_DYNAMIC_CODE conditional and redundant variants, kept only UniversalTransitionTailCall |
| src/coreclr/nativeaot/Runtime/amd64/UniversalTransition.S | Removed FEATURE_DYNAMIC_CODE conditional and redundant variants, kept only UniversalTransitionTailCall |
| src/coreclr/nativeaot/Runtime/amd64/CachedInterfaceDispatchAot.asm | Removed duplicate EXTERN declarations and updated to use renamed RhpUniversalTransitionTailCall |
| src/coreclr/nativeaot/Runtime/amd64/CachedInterfaceDispatchAot.S | Updated jump to use renamed RhpUniversalTransitionTailCall |
| src/coreclr/nativeaot/Runtime/StackFrameIterator.cpp | Removed FEATURE_DYNAMIC_CODE conditional, updated return address checks to use only ReturnFromUniversalTransitionTailCall |
| src/coreclr/nativeaot/Runtime/CMakeLists.txt | Removed FEATURE_CUSTOM_IMPORTS and FEATURE_DYNAMIC_CODE feature definitions |
MichalStrehovsky
approved these changes
Dec 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Left-over from .NET Native calling convention converter. We only need the tailcall variant of universal transition.