Skip to content

Conversation

Copy link
Contributor

Copilot AI commented Dec 17, 2025

Description

The LibraryMode test variant with useWasmSdk: False, isPublish: True is expected to fail, but the test was asserting success for all variants.

Updated test to set ExpectSuccess: false when publishing without WASM SDK, verifying the operation exits with code 1 as expected.

// Publishing without WASM SDK is expected to fail
bool expectSuccess = useWasmSdk || !isPublish;
if (isPublish)
    PublishProject(info, config, new PublishOptions(AssertAppBundle: useWasmSdk, ExpectSuccess: expectSuccess));
else
    BuildProject(info, config, new BuildOptions(AssertAppBundle: useWasmSdk, ExpectSuccess: expectSuccess));

Customer Impact

No customer impact - test-only change.

Regression

No. Test was incomplete, not validating the expected failure scenario.

Testing

Test compiles successfully. The updated test will properly validate all four variants:

  • Build without SDK: succeeds
  • Build with SDK: succeeds
  • Publish with SDK: succeeds
  • Publish without SDK: fails (now correctly validated)

Risk

Minimal - test-only change with no production code impact.


✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

Copilot AI changed the title [WIP] Fix test variant for library mode without workload Fix LibraryMode test to expect publish failure without WASM SDK Dec 17, 2025
Copilot AI requested a review from maraf December 17, 2025 19:08
@maraf maraf marked this pull request as ready for review December 17, 2025 19:50
@maraf maraf requested a review from ilonatommy as a code owner December 17, 2025 19:50
@maraf maraf merged commit 5f80cfd into maraf/BrowserLibraryModeNoWorkload Dec 17, 2025
12 of 14 checks passed
@maraf maraf deleted the copilot/sub-pr-122607 branch December 17, 2025 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants