Revert "[Tests][UserEvents] Add userevents functional runtime tests" #122394
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
needs-area-label
ericstj
approved these changes
Dec 10, 2025
Member
|
/ba-g fasttrack to unbreak official build |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR reverts PR #122134 which added user events functional runtime tests, due to official build breakage. The revert removes all test infrastructure, test scenarios, and related configuration changes that were introduced in the original PR.
- Removes 5 test scenarios for user events: basic, activity, managedevent, custommetadata, and multithread
- Removes shared test infrastructure (UserEventsTestRunner and UserEventsRequirements)
- Reverts TraceEvent version from 3.1.28 back to 3.1.16 and removes MicrosoftOneCollectRecordTrace package reference
- Cleans up build system references from build.proj, helixpublishwitharcade.proj, and issues.targets
Reviewed changes
Copilot reviewed 24 out of 24 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/tests/tracing/userevents/multithread/* | Removes multithread test scenario files (script, csproj, cs) |
| src/tests/tracing/userevents/managedevent/* | Removes managed event test scenario files (script, csproj, cs) |
| src/tests/tracing/userevents/custommetadata/* | Removes custom metadata test scenario files (script, csproj, cs) |
| src/tests/tracing/userevents/basic/* | Removes basic test scenario files (script, csproj, cs) |
| src/tests/tracing/userevents/activity/* | Removes activity test scenario files (script, csproj, cs) |
| src/tests/tracing/userevents/common/* | Removes shared test infrastructure including UserEventsTestRunner.cs, UserEventsRequirements.cs, userevents_common.csproj, and NuGet.config |
| src/tests/tracing/userevents/README.md | Removes documentation for user events functional tests |
| src/tests/issues.targets | Removes exclusion for user events tests on Mono |
| src/tests/build.proj | Removes reference to userevents_common.csproj from restore projects |
| src/tests/Common/helixpublishwitharcade.proj | Removes logic for handling extra test executables list files and chmod commands for extra executables |
| eng/Versions.props | Reverts TraceEvent version from 3.1.28 to 3.1.16 and removes MicrosoftOneCollectRecordTraceVersion |
This was referenced Dec 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #122134
The official build broke