-
Notifications
You must be signed in to change notification settings - Fork 5.3k
Switch default CI focus to osx-arm64 for CoreCLR PRs #122085
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Co-authored-by: agocke <[email protected]>
|
Interesting. This seems like a change we should have made a while ago! Nice catch/change. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR switches the default CI focus from osx-x64 to osx-arm64 for CoreCLR PRs, reflecting Apple Silicon (ARM64) as the primary macOS architecture. The changes swap platform configurations so that osx-arm64 now runs libraries debug tests by default, while osx-x64 falls back to priority 0 tests only.
Key Changes:
- Swapped
osx_x64andosx_arm64in build job platform matrices for CoreCLR_Libraries and Libraries_CheckedCoreCLR configurations - Updated CoreCLR runtime test execution and libraries test execution jobs to prioritize
osx-arm64 - Changed condition triggers for
osx_x64jobs fromcoreclr_AppleSiliconto standardcoreclrchange detection
Co-authored-by: agocke <[email protected]>
|
We should delete this line
-cross on build line.
One of the reason was Azure DevOps wasn't providing Microsoft-Hosted macOS arm64 images https://learn.microsoft.com/azure/devops/release-notes/roadmap/macos-agents-apple-silicon (while GitHub was). This changed a few weeks ago when they started previewing arm64 images: https://devblogs.microsoft.com/devops/upcoming-updates-for-azure-pipelines-agents-images/#mac-os. cc @steveisok |
|
If the runtime is complete broken on osx-x64 (e.g. "Hello world" does not work), where is the first place we are going to find out after this change? (just asking to have a better idea how things are setup) |
cherry-pick am11@63d4ae8, so we can be sure it's picking up the correct machine. |
|
Actually @am11 this is just testing, not build, so I don't think this is necessary yet. When we start using macos ARM64 machines for build, then it will be. |
9b974e0 to
fee3e56
Compare
Interesting, I didn't know that. Lemme look closer at the proposed change. |
|
It looks like this change is too broad -- it's affecting normal builds, not just Helix builds. |
9978cad to
1c55383
Compare
|
OK, this change passes without changing |
|
I'm not sure if helix had any role here. As explained above, with -cross, the build uses cached cmake check and assumes "I can't treat this build machine as target". We can potentially break build for native machine (people using osx-arm64 are not passing -cross for native arch build) while CI will always appear green. The real error was: and it is failing because the cmake detection was failing; something in osx-arm64 machine is not "normal" which we needed to figure out and fix before merging. To do that, we get the cmake log file and investigate. |
Apple Silicon (ARM64) is now the primary macOS architecture. This PR swaps
osx-x64andosx-arm64in the default CI matrix so thatosx-arm64runs libraries debug tests by default, whileosx-x64falls back to priority 0 tests only.Changes to
eng/pipelines/runtime.ymlBuild jobs:
CoreCLR_Librarieswithlibs.tests:osx_x64→osx_arm64CoreCLR_Librarieswithout tests (installer deps):osx_arm64→osx_x64Libraries_CheckedCoreCLRwithlibs.tests:osx_x64→osx_arm64Libraries_CheckedCoreCLRwithout tests:osx_arm64→osx_x64Test execution jobs:
osx_x64→osx_arm64osx_x64→osx_arm64Dependency updates:
Installer_Build_And_Testartifact dependencies swapped to match new build configurationsosx_x64condition updated fromAppleSilicontrigger to standardcoreclrchange detectionThe platform matrix comment table updated to reflect
osx-arm64in the debug test configuration (using lowercase RID format for consistency).Original prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.