-
Notifications
You must be signed in to change notification settings - Fork 5.3k
Remove audit sources from NuGet.config #120696
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The api.nuget.org source will clash with the CFSClean network isolation policy
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR removes the audit sources configuration from NuGet.config to resolve network isolation policy conflicts. The api.nuget.org source in the audit configuration was clashing with the CFSClean network isolation policy.
Key Changes
- Removed the entire
<auditSources>section from NuGet.config - Eliminated the reference to api.nuget.org that was causing network policy conflicts
|
Tagging subscribers to this area: @dotnet/runtime-infrastructure |
|
/backport to release/10.0 |
|
Started backporting to |
|
/backport to release/9.0-staging |
|
Started backporting to |
Backport of #120696 to release/9.0-staging /cc @akoeplinger ## Customer Impact - [ ] Customer reported - [X] Found internally no customer impact, this affects our internal builds due to CFS restrictions. ## Regression - [ ] Yes - [X] No ## Testing Tested in CI. ## Risk None. This just changes a setting for nuget package restore. **IMPORTANT**: If this backport is for a servicing release, please verify that: - For .NET 8 and .NET 9: The PR target branch is `release/X.0-staging`, not `release/X.0`. - For .NET 10+: The PR target branch is `release/X.0` (no `-staging` suffix). ## Package authoring no longer needed in .NET 9 **IMPORTANT**: Starting with .NET 9, you no longer need to edit a NuGet package's csproj to enable building and bump the version. Keep in mind that we still need package authoring in .NET 8 and older versions. Co-authored-by: Alexander Köplinger <[email protected]>
Backport of #120696 to release/10.0 /cc @akoeplinger ## Customer Impact - [ ] Customer reported - [x] Found internally no customer impact, this affects our internal builds due to CFS restrictions. ## Regression - [ ] Yes - [x] No ## Testing Tested in CI. ## Risk None. This just changes a setting for nuget package restore. **IMPORTANT**: If this backport is for a servicing release, please verify that: - For .NET 8 and .NET 9: The PR target branch is `release/X.0-staging`, not `release/X.0`. - For .NET 10+: The PR target branch is `release/X.0` (no `-staging` suffix). ## Package authoring no longer needed in .NET 9 **IMPORTANT**: Starting with .NET 9, you no longer need to edit a NuGet package's csproj to enable building and bump the version. Keep in mind that we still need package authoring in .NET 8 and older versions. Co-authored-by: Alexander Köplinger <[email protected]>
The api.nuget.org source will clash with the CFSClean network isolation policy and the same data is provided by AzDO now.