Skip to content

Conversation

@jeffhandley
Copy link
Member

This errant text snuck in with (#119584) Add MetadataUpdateDeletedAttribute.

@jeffhandley jeffhandley requested a review from steveisok October 9, 2025 19:29
@jeffhandley jeffhandley self-assigned this Oct 9, 2025
Copilot AI review requested due to automatic review settings October 9, 2025 19:29
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes a corrupted assert message that contained errant text that was accidentally pasted in during a previous change. The fix corrects a string interpolation in an assertion message to properly display the expected error text.

@dotnet-policy-service
Copy link
Contributor

Tagging subscribers to this area: @dotnet/area-system-reflection
See info in area-owners.md if you want to be subscribed.

@jeffhandley jeffhandley merged commit 4839d27 into dotnet:main Oct 9, 2025
88 checks passed
@jeffhandley jeffhandley deleted the jeffhandley/fix-assert-message branch October 9, 2025 22:39
jeffhandley added a commit to jeffhandley/runtime that referenced this pull request Oct 9, 2025
steveisok added a commit that referenced this pull request Oct 14, 2025
…ering (#120572)

* Add MetadataUpdateDeletedAttribute (#119584)

This attribute is intended to be emitted only by Roslyn. Its intent is to be used by reflection
as a filter to "remove" types and members that have been deleted during a hot reload session.

Implements #118903

* Add ability to filter members in reflection and test

---------

Co-authored-by: Tomas Matousek <[email protected]>

* Fix assert message with errant text pasted in (#120574)

---------

Co-authored-by: Steve Pfister <[email protected]>
Co-authored-by: Tomas Matousek <[email protected]>
@github-actions github-actions bot locked and limited conversation to collaborators Nov 9, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants