Add File hard link API and tests #120041
Merged
Add File hard link API and tests #120041
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduce `File.CreateHardLink` and `FileSystemInfo.CreateAsHardLink` APIs to create hard links, with platform-specific implementations. Add comprehensive tests for hard link creation, behavior, and error cases for both File and FileInfo. Implements dotnet#69030
dotnet-policy-service
bot
added
the
community-contribution
Contributor
Author
|
@dotnet-policy-service agree |
jkotas
reviewed
Sep 24, 2025
src/coreclr/nativeaot/System.Private.CoreLib/src/CompatibilitySuppressions.xml
Outdated
Show resolved
Hide resolved
3 tasks
Contributor
There was a problem hiding this comment.
Pull Request Overview
This pull request adds hard link creation APIs to .NET, implementing File.CreateHardLink and FileSystemInfo.CreateAsHardLink methods with platform-specific implementations for Windows and Unix systems.
Key changes:
- Introduce public APIs for creating hard links in both File and FileSystemInfo classes
- Add platform-specific implementations using Windows Kernel32 and Unix system calls
- Implement comprehensive test coverage for hard link functionality
Reviewed Changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/libraries/System.Runtime/ref/System.Runtime.cs | Add public API signatures for CreateHardLink methods |
| src/libraries/System.Private.CoreLib/src/System/IO/File.cs | Implement File.CreateHardLink static method |
| src/libraries/System.Private.CoreLib/src/System/IO/FileSystemInfo.cs | Implement CreateAsHardLink instance method |
| src/libraries/System.Private.CoreLib/src/System/IO/FileSystem.Windows.cs | Windows-specific hard link implementation using Kernel32 |
| src/libraries/System.Private.CoreLib/src/System/IO/FileSystem.Unix.cs | Unix-specific hard link implementation using link system call |
| src/libraries/System.Private.CoreLib/src/System.Private.CoreLib.Shared.projitems | Add Windows interop reference for CreateHardLink |
| src/libraries/Common/tests/System/IO/ReparsePointUtilities.cs | Add hard link test utilities and capability detection |
| src/libraries/System.Runtime/tests/System.IO.FileSystem.Tests/Base/HardLinks/BaseHardLinks.FileSystem.cs | Base test class with common hard link test scenarios |
| src/libraries/System.Runtime/tests/System.IO.FileSystem.Tests/File/HardLinks.cs | Tests for File.CreateHardLink API |
| src/libraries/System.Runtime/tests/System.IO.FileSystem.Tests/FileInfo/HardLinks.cs | Tests for FileInfo.CreateAsHardLink API |
| src/libraries/System.Runtime/tests/System.IO.FileSystem.Tests/System.IO.FileSystem.Tests.csproj | Add test files to project compilation |
src/libraries/System.Private.CoreLib/src/System/IO/FileSystemInfo.cs
Outdated
Show resolved
Hide resolved
Co-authored-by: Copilot <[email protected]>
This was referenced Sep 24, 2025
No functional changes.
Calling `File.WriteAllText` (creates the file if it does not exist) right after `CreateFile` might be redundant
Contributor
Author
|
Hi. May I ask the current review status of this PR? |
Contributor
Author
|
@adamsitnik Thanks for your review! All review comments have been addressed. However this ConditionalClass comment requires your attention. |
adamsitnik
reviewed
Oct 20, 2025
Member
adamsitnik
left a comment
adamsitnik
left a comment
There was a problem hiding this comment.
It looks very good, PTAL at my comments regarding test cleanup.
src/libraries/System.Formats.Tar/src/System/Formats/Tar/TarEntry.Unix.cs
Show resolved
Hide resolved
...s/System.Runtime/tests/System.IO.FileSystem.Tests/Base/HardLinks/BaseHardLinks.FileSystem.cs
Show resolved
Hide resolved
...s/System.Runtime/tests/System.IO.FileSystem.Tests/Base/HardLinks/BaseHardLinks.FileSystem.cs
Show resolved
Hide resolved
...s/System.Runtime/tests/System.IO.FileSystem.Tests/Base/HardLinks/BaseHardLinks.FileSystem.cs
Show resolved
Hide resolved
3 tasks
jozkee
reviewed
Oct 20, 2025
...s/System.Runtime/tests/System.IO.FileSystem.Tests/Base/HardLinks/BaseHardLinks.FileSystem.cs
Outdated
Show resolved
Hide resolved
7 tasks
jozkee
reviewed
Oct 21, 2025
adamsitnik
approved these changes
Oct 21, 2025
Member
adamsitnik
left a comment
adamsitnik
left a comment
There was a problem hiding this comment.
LGTM, big thanks for your contribution @SadPencil !
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce
File.CreateHardLinkandFileSystemInfo.CreateAsHardLinkAPIs to create hard links, with platform-specific implementations. Add comprehensive tests for hard link creation, behavior, and error cases for both File and FileInfo.Implements and closes #69030