[RuntimeAsync] Enable async feature/tests #119420
Conversation
VSadov
changed the title
| <PropertyGroup> | ||
| <RunAnalyzers>true</RunAnalyzers> | ||
| <NoWarn>$(NoWarn);xUnit1013;CS1998</NoWarn> | ||
| <NoWarn>$(NoWarn);xUnit1013;CS1998;SYSLIB5007</NoWarn> |
There was a problem hiding this comment.
@tommcdon The SYSLIB5007nowarn is to suppress warnings about using experimental API. CompilerServices/AsyncHelpers where the Await helpers live is still marked as experimental.
It will not be experimental in at some point, hopefully soon.
There was a problem hiding this comment.
Also note the <Features>$(Features);runtime-async=on</Features> below - that enables the new style codegen for async/await on the Roslyn side.
Right now we enable this only for tests under tests/async, if we build that at all.
There was a problem hiding this comment.
nowarn for SYSLIB5007 should no longer be needed
src/tests/async/struct/struct.cs
Outdated
| } | ||
|
|
||
| // Roslyn NYI - async in structs. Remove opt-out once supported. | ||
| [System.Runtime.CompilerServices.RuntimeAsyncMethodGeneration(false)] |
There was a problem hiding this comment.
This is no longer needed either.
There was a problem hiding this comment.
The NYI has been implemented.
VSadov
force-pushed
the
asyncTest
branch
3 times, most recently
from
2cf4728 to
4da8472
Compare
1 participant
Mostly to check the current state of build/tests, although maybe we could merge this ? . . .
(perhaps not yet, while there is still some backporting to v10)