Fixes trying to create a module using a trash as the address of the module #119031
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
needs-area-label
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a bug where trash values in vmModule could cause incorrect module creation during debugging operations. The issue was introduced in a previous PR that simplified module lookup logic but inadvertently allowed uninitialized vmModule values to be used as valid addresses.
- Explicitly sets
vmModuleto NULL to prevent using uninitialized/trash values - Prevents creation of spurious modules with invalid addresses in the debugger
hoyosjs
approved these changes
Aug 23, 2025
This was referenced Aug 23, 2025
teo-tsirpanis
added
area-Diagnostics-coreclr
and removed
needs-area-label
Contributor
|
Tagging subscribers to this area: @steveisok, @dotnet/dotnet-diag |
Member
Author
|
/backport to release/10.0 |
Contributor
|
Started backporting to release/10.0: https://github.com/dotnet/runtime/actions/runs/17209922808 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR #118414, this code was changed:
FROM:
pModule = m_modules.GetBase(vmDomainAssembly.IsNull() ? VmPtrToCookie(vmModule) : mPtrToCookie(vmDomainAssembly));TO:
pModule = m_modules.GetBase(VmPtrToCookie(vmModule));But vmModule can contain trash value so it will not find a module in m_module and this will make it try to create a new module using this trash address in the CordbModule constructor.
I don't know if this needs to be fixed in other places, but this place for sure is causing issues. Not sure how it was not detected on other platforms, I detected it on android.