Skip to content

Conversation

@kg
Copy link
Member

@kg kg commented Aug 22, 2025

Adds support for IAT_PVALUE string literals and removes INTOP_LDIND_O. This fixes JIT\regression\jitblue\Runtime_100437

Copilot AI review requested due to automatic review settings August 22, 2025 16:53
@kg kg requested review from BrzVlad and janvorli as code owners August 22, 2025 16:53
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds support for IAT_PVALUE string literals in the CoreCLR interpreter, enabling proper handling of string references that require indirection. The key enhancement is implementing the INTOP_LDIND_O instruction and updating the string literal compilation logic to handle both direct (IAT_VALUE) and indirect (IAT_PVALUE) string access patterns.

Key changes:

  • Implements INTOP_LDIND_O instruction for object indirection in the interpreter execution engine
  • Updates string literal compilation to handle IAT_PVALUE access type with proper indirection logic
  • Reorganizes instruction generation order to support the new indirection pattern

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
src/coreclr/vm/interpexec.cpp Adds INTOP_LDIND_O case to interpreter execution switch statement
src/coreclr/interpreter/compiler.cpp Updates string literal compilation to handle IAT_PVALUE with indirection and reorganizes instruction data assignment

@dotnet-policy-service
Copy link
Contributor

Tagging subscribers to this area: @BrzVlad, @janvorli, @kg
See info in area-owners.md if you want to be subscribed.

@kg kg merged commit 0b1f401 into dotnet:main Aug 30, 2025
95 of 97 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Sep 29, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants