-
Notifications
You must be signed in to change notification settings - Fork 5.3k
[RISC-V] R2RDump: revamp probing quirks #118980
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@risc-vv /run |
RISC-V pull_request-CLR-QEMU: 9106 / 9136 (99.67%)report.xml, report.md, failures.xml, testclr_details.tar.zst RISC-V pull_request-CLR-VF2: 9107 / 9137 (99.67%)report.xml, report.md, failures.xml, testclr_details.tar.zst RISC-V pull_request-FX-QEMU: 0 / 1 (0.00%)report.xml, report.md, failures.xml, testclr_details.tar.zst RISC-V pull_request-FX-VF2: 0 / 67 (0.00%)report.xml, report.md, failures.xml, testclr_details.tar.zst Build information and commandsGIT: |
|
We will review .NET 11 PRs when we are done with .NET 10 last minute works and less busy. Please give us a few more weeks. |
jakobbotsch
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Anyone else from @dotnet/crossgen-contrib want to take a look?
|
/azp run runtime |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
@tomeksowi please check test failures. |
Failing on Send to Helix, looks unrelated. |
|
/ba-g Android timeout and known issue #114924 |
Bring back
ProbeRiscV64Quirksdisabled in #117408, see #117408 (comment) for context.I reimplemented it to avoid iterating the instruction stream backwards, which is impossible with compressed instructions without keeping a backlog of seen instruction sizes.
The new implementation recognizes only canonical
auipc + jalr/ld/addipatterns. On one hand it introduces a temporary inconvenience of putting the cell name next to unnecessaryaddiinstead ofld/jalrfor patterns like this:On the other hand, it is much simpler (one third of the original code size) and comments on all handles (e.g. strings), the hitherto implementation limited itself to only to calls.
Compressed
jalr/ld/addiare not recognized yet, they will be implemented as we teach JIT to emit these encodings.Part of #84834, cc @dotnet/samsung