-
Notifications
You must be signed in to change notification settings - Fork 5.3k
Add 'physicalMemoryMode' to SRC.MemoryCache. New mode will follow GC metrics to determine trimming. #117886
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: release/8.0
Are you sure you want to change the base?
Add 'physicalMemoryMode' to SRC.MemoryCache. New mode will follow GC metrics to determine trimming. #117886
Changes from all commits
8f10bce
6d7c62f
4740ffd
7b8e545
19d9b44
198ee08
cbe88f9
d837e70
4b3cff6
441410c
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||||
|---|---|---|---|---|---|---|---|---|
| @@ -0,0 +1,35 @@ | ||||||||
| // Licensed to the .NET Foundation under one or more agreements. | ||||||||
| // The .NET Foundation licenses this file to you under the MIT license. | ||||||||
|
|
||||||||
| using System; | ||||||||
| using System.Collections.Specialized; | ||||||||
| using System.Security; | ||||||||
| using System.Runtime.InteropServices; | ||||||||
|
Comment on lines
+5
to
+7
|
||||||||
| using System.Collections.Specialized; | |
| using System.Security; | |
| using System.Runtime.InteropServices; |
Copilot
AI
Dec 4, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Extra blank line. There's an unnecessary blank line after the using directives. Per .editorconfig standards, there should be only one blank line between the using statements and the namespace declaration.
Copilot
AI
Dec 4, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Inconsistent product name: ".Net Core" should be ".NET Core" (with capital letters for both parts). This appears twice in the comments on lines 23 and 28.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The ArgumentException is thrown with a null message, making it unhelpful to users. It should follow the pattern of other ConfigUtil methods and use a formatted resource string like
RH.Format(SR.Value_must_be_valid_enum, valueName, rawValue)to provide clear feedback about the invalid value.