Skip to content

[browser] remove profiler from samples #114428

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
pavelsavara merged 1 commit into from
Apr 9, 2025
Merged

[browser] remove profiler from samples #114428

pavelsavara merged 1 commit into from
Apr 9, 2025

Conversation

@pavelsavara
Copy link
Member

@pavelsavara pavelsavara commented Apr 9, 2025 •
edited
Loading

@pavelsavara pavelsavara added arch-wasm WebAssembly architecture area-Build-mono os-browser Browser variant of arch-wasm labels Apr 9, 2025
@pavelsavara pavelsavara added this to the 10.0.0 milestone Apr 9, 2025
@pavelsavara pavelsavara self-assigned this Apr 9, 2025
Copilot AI review requested due to automatic review settings April 9, 2025 09:27
@pavelsavara pavelsavara requested a review from lewing as a code owner April 9, 2025 09:27
Copilot AI reviewed Apr 9, 2025
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review any files in this pull request.

Files not reviewed (1)
  • src/mono/sample/wasm/Directory.Build.targets: Language not supported

@pavelsavara pavelsavara mentioned this pull request Apr 9, 2025
Merged
@dotnet-policy-service
Copy link
Contributor

dotnet-policy-service bot commented Apr 9, 2025

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

@build-analysis build-analysis bot mentioned this pull request Apr 9, 2025
Open
@pavelsavara pavelsavara merged commit 1099560 into dotnet:main Apr 9, 2025
28 of 30 checks passed
@pavelsavara pavelsavara deleted the browser_bench_opt_out_profiler branch April 9, 2025 14:08
@github-actions github-actions bot locked and limited conversation to collaborators May 10, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

Copilot code review Copilot Copilot left review comments

@maraf maraf maraf approved these changes

@lewing lewing Awaiting requested review from lewing lewing is a code owner

Assignees

@pavelsavara pavelsavara

Labels

arch-wasm WebAssembly architecture area-Build-mono os-browser Browser variant of arch-wasm

Projects

None yet

Milestone

10.0.0

Development

Successfully merging this pull request may close these issues.

2 participants

@pavelsavara @maraf