Change NativeAOT asset input resolution to explicitly replace only assemblies that come from the non-NativeAOT runtime package #111944
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ly check that they're coming from the runtime pack instead of checking file version numbers and using that as a heuristic for the same thing.
jkoritzinsky
changed the title
|
Tagging subscribers to this area: @agocke, @MichalStrehovsky, @jkotas |
|
Is this fixing an observable bug or is it a cleanup? |
|
This is cleanup. Its not fixing a bug. Its mainly focused on making the selection rule sound by-design and not trying to duplicate the work done by the many conflict-resolution algorithms in the SDK. |
Open
3 tasks
sbomer
approved these changes
Jan 29, 2025
|
/ba-g timeouts unrelated |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rewrite how we swap assemblies out as part of NativeAOT to specifically check that they're coming from the runtime pack instead of checking file version numbers and using that as a heuristic for the same thing.
Validated locally that OOB packages are preferred over the in-box assembly, native assets from Microsoft.NETCore.App.Runtime are excluded, and that the WindowsBase.dll from WindowsDesktop is preferred over WindowsBase.dll from NativeAOT.