Skip to content

Don't do opportunistic ISA lightup if there are plans to run the AltJit code #110419

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tannergooding merged 2 commits into from
Dec 6, 2024
Merged

Don't do opportunistic ISA lightup if there are plans to run the AltJit code #110419

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ea29e28
Don't do opportunistic ISA lightup if there are plans to run the AltJ…
tannergooding Dec 4, 2024
a6c743d
Ensure that we can compile in Release builds
tannergooding Dec 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion src/coreclr/jit/compiler.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6048,7 +6048,16 @@ int Compiler::compCompile(CORINFO_MODULE_HANDLE classPtr,
// but it requires moving the whole set of logic down into compCompileHelper after compInitOptions has
// run and we're going to end up exiting early if JIT_FLAG_ALT_JIT and opts.altJit don't match anyways

if (!info.compMatchedVM || compileFlags->IsSet(JitFlags::JIT_FLAG_ALT_JIT))
bool enableAvailableIsas = !info.compMatchedVM;

#ifdef DEBUG
if (compileFlags->IsSet(JitFlags::JIT_FLAG_ALT_JIT) && JitConfig.RunAltJitCode() == 0)
{
enableAvailableIsas = true;
}
#endif // DEBUG

if (enableAvailableIsas)
{
CORINFO_InstructionSetFlags instructionSetFlags;

Expand Down
Loading