-
Notifications
You must be signed in to change notification settings - Fork 5.3k
Move GetRefAny (with FCThrow) to managed #110344
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
6f3f4cc
dc3c90b
aaf86b2
e3eb068
acbb049
3015a55
2969b3b
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -1382,24 +1382,6 @@ HCIMPL2(Object*, JIT_Box, CORINFO_CLASS_HANDLE type, void* unboxedData) | |
| } | ||
| HCIMPLEND | ||
|
|
||
| /*************************************************************/ | ||
| HCIMPL2_IV(LPVOID, JIT_GetRefAny, CORINFO_CLASS_HANDLE type, TypedByRef typedByRef) | ||
| { | ||
| FCALL_CONTRACT; | ||
|
|
||
| TypeHandle clsHnd(type); | ||
| // <TODO>@TODO right now we check for precisely the correct type. | ||
| // do we want to allow inheritance? (watch out since value | ||
| // classes inherit from object but do not normal object layout).</TODO> | ||
| if (clsHnd != typedByRef.type) { | ||
| FCThrow(kInvalidCastException); | ||
| } | ||
|
|
||
| return(typedByRef.data); | ||
| } | ||
| HCIMPLEND | ||
|
|
||
|
|
||
| /*************************************************************/ | ||
| HCIMPL2(BOOL, JIT_IsInstanceOfException, CORINFO_CLASS_HANDLE type, Object* obj) | ||
|
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @jkotas, there is a QCall
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think
I am not sure what you mean by this. This QCall is not related to any asm helpers.
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Ah, sorry I thought COMPlusThrow ends up using C++ exception and confusing it with your comment in earlier PR #109087 (comment). |
||
| { | ||
|
|
||
Uh oh!
There was an error while loading. Please reload this page.