Skip to content

JIT: Refine assert for RMW check in crc32 and hw intrinsic codegen #108750

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jakobbotsch merged 9 commits into from
Aug 7, 2025
Merged

JIT: Refine assert for RMW check in crc32 and hw intrinsic codegen #108750

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
b12fae9
JIT: Refine assert for RMW check in crc32 codegen
jakobbotsch Oct 10, 2024
0050cb2
Extract a function
jakobbotsch Dec 10, 2024
0313512
Add to assert, run jit-format
jakobbotsch Dec 10, 2024
297cafd
Merge branch 'main' of github.com:dotnet/runtime into fix-108601
jakobbotsch Aug 6, 2025
52d5e18
Run jit-format
jakobbotsch Aug 6, 2025
576794c
Fix other assert too
jakobbotsch Aug 6, 2025
cd08a48
Update src/coreclr/jit/codegenxarch.cpp
jakobbotsch Aug 6, 2025
2830bd6
Fix build for arm64
jakobbotsch Aug 6, 2025
eadb638
Fix some of the other asserts when straightforward
jakobbotsch Aug 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 16 additions & 1 deletion src/coreclr/jit/hwintrinsiccodegenxarch.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2240,7 +2240,22 @@ void CodeGen::genSSE42Intrinsic(GenTreeHWIntrinsic* node, insOpts instOptions)
{
assert(instOptions == INS_OPTS_NONE);

assert(!op2->isUsedFromReg() || (op2->GetRegNum() != targetReg) || (op1Reg == targetReg));
#ifdef DEBUG
if (op2->isUsedFromReg() && (op2->GetRegNum() == targetReg) && (op1Reg != targetReg))
{
// The move we are issuing is going to overwrite 'op2' with
// 'op1'. This is still ok if 'op1' and 'op2' are the same
// local; normally they would be in the same register in that
// case, but LSRA may have inserted a copy for one of the
// operands (either due to stress or for any other reason).
// This check mirrors what happens in genCodeForBinary.
GenTree* op1Skip = op1->gtSkipReloadOrCopy();
GenTree* op2Skip = op2->gtSkipReloadOrCopy();
assert(op1Skip->OperIsLocalRead() && GenTree::Compare(op1Skip, op2Skip) &&
"'mov' to set up crc32 RMW is going to overwrite op2!");
}
#endif

emit->emitIns_Mov(INS_mov, emitTypeSize(targetType), targetReg, op1Reg, /* canSkip */ true);

if ((baseType == TYP_UBYTE) || (baseType == TYP_USHORT)) // baseType is the type of the second argument
Expand Down