ARM-SVE: Add LD/ST info to SVE instructions #105512 #106328
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
area-CodeGen-coreclr
dotnet-policy-service
bot
added
the
community-contribution
a74nh
changed the title
Contributor
Author
|
@dotnet/arm64-contrib @kunalspathak |
kunalspathak
approved these changes
Aug 13, 2024
Contributor
kunalspathak
left a comment
kunalspathak
left a comment
There was a problem hiding this comment.
LGTM. I assume all sve stress tests passes.
Contributor
Author
Yes, they all work. It takes 50mins to run all the stress tests for RO on my machine. Thankfully I don't think it will be added to the CI like that. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #105512
Added
LD,STandCMPflags to all the relevant SVE instructions.(I don't think
CMPis checked anywhere, but did it anyway).