Skip to content

Conversation

@maraf
Copy link
Member

@maraf maraf commented Jul 22, 2024

With #103755 in place, custom cache is not needed anymore

@maraf maraf added arch-wasm WebAssembly architecture area-Build-mono os-browser Browser variant of arch-wasm labels Jul 22, 2024
@maraf maraf added this to the 9.0.0 milestone Jul 22, 2024
@maraf maraf self-assigned this Jul 22, 2024
@maraf maraf requested review from akoeplinger and lewing as code owners July 22, 2024 12:07
@dotnet-policy-service
Copy link
Contributor

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

@maraf maraf requested review from ilonatommy and pavelsavara July 22, 2024 12:07
@pavelsavara
Copy link
Member

The cache code could be deleted (to reduce size & complexity).
Do we have good reason to keep it ?

@maraf
Copy link
Member Author

maraf commented Jul 22, 2024

The cache code could be deleted (to reduce size & complexity).
Do we have good reason to keep it ?

It's still useful when users disable fingerprinting. I would prefer leaving it place for 9 and discuss more about removing it for 10.

@maraf
Copy link
Member Author

maraf commented Jul 23, 2024

/ba-g previous run was green

@maraf maraf merged commit 705a548 into dotnet:main Jul 23, 2024
@maraf maraf deleted the BrowserTurnOffCustomCache branch July 23, 2024 05:16
@maraf
Copy link
Member Author

maraf commented Jul 23, 2024

/backport to release/9.0-preview7

@github-actions
Copy link
Contributor

Started backporting to release/9.0-preview7: https://github.com/dotnet/runtime/actions/runs/10053151858

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

arch-wasm WebAssembly architecture area-Build-mono os-browser Browser variant of arch-wasm

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants