Restore OfficialBuildId for proper CI versioning #33209
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The default _OfficialBuildIdArgs was changed to empty in commit 4fcc7b2, which caused builds to be treated as PR validation builds instead of official CI builds. This resulted in packages having version 10.0.30-ci instead of the expected 10.0.30-ci.main.YYMMDD.r format.
jfversluis
added
the
area-infrastructure
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses a CI build versioning issue where packages were incorrectly labeled as 10.0.30-ci instead of the expected date-based format 10.0.30-ci.main.YYMMDD.r. The fix restores the proper OfficialBuildId configuration that was inadvertently removed in a previous commit and corrects a typo in the variable name.
Key changes:
- Restores default value for
_OfficialBuildIdArgsto properly passOfficialBuildIdto MSBuild - Fixes typo:
_BuildOfficalId→_BuildOfficialId
Fixed in all pipeline files: - eng/pipelines/arcade/variables.yml - eng/pipelines/ci-official.yml - eng/pipelines/handlers.yml - eng/pipelines/common/sdk-insertion.yml - eng/pipelines/common/variables.yml
jfversluis
force-pushed
the
fix/restore-official-build-id-versioning
branch
from
0af51fd to
79911a2
Compare
Include PR number in the actual package version by modifying PreReleaseVersionLabel for PR builds. This ensures the PR number is part of the NuGet package version, not just build metadata. PR builds will now have versions like: 10.0.30-ci.main.pr12345.25618.1 Instead of just: 10.0.30-ci
jfversluis
force-pushed
the
fix/restore-official-build-id-versioning
branch
from
7cee73f to
5dcc9e1
Compare
This was referenced Dec 18, 2025
Pass PreReleaseVersionLabel=ci.pr{number} through build args only for PR builds
(Build.Reason == PullRequest) so the PR number appears in the actual package
version, not just metadata. CI and nightly builds remain unaffected.
jfversluis
force-pushed
the
fix/restore-official-build-id-versioning
branch
from
9d1289d to
8548976
Compare
jfversluis
added
the
p/0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note
Are you waiting for the changes in this PR to be merged?
It would be very helpful if you could test the resulting artifacts from this PR and let us know in a comment if this change resolves your issue. Thank you!
Description
This PR fixes CI and PR build versioning issues and includes several improvements to the pipeline configuration.
Root Cause
In commit 4fcc7b2, the default
_OfficialBuildIdArgswas changed to an empty string. This caused theOfficialBuildIdto not be passed to builds, resulting in Arcade treating them as PR validation builds instead of official CI builds. Packages were being labeled as10.0.30-ciinstead of the expected format10.0.30-ci.main.YYMMDD.r.Changes
Restore default
_OfficialBuildIdArgs: The default value now passesOfficialBuildIdto the build process, which enables proper versioning with the date-based suffix.Fix typo across multiple files:
_BuildOfficalId→_BuildOfficialId(fixed in 6 locations)Include PR number in package version for PR builds: PR builds now use
PreReleaseVersionLabel=ci.pr{number}so the PR number appears in the actual NuGet package filename, not just in build metadata.Expected Results
CI builds from the main branch will produce packages with versions like:
10.0.30-ci.main.25618.1(where25618is SHORT_DATE and1is the daily revision)PR builds will produce packages with versions like:
10.0.30-ci.pr33209.25618.1(where33209is the PR number)Instead of the previous broken format:
10.0.30-ciFiles Changed
eng/pipelines/arcade/variables.yml- Main fix + PR version labeleng/pipelines/ci-official.yml- Typo fixeng/pipelines/handlers.yml- Typo fix (2 occurrences)eng/pipelines/common/sdk-insertion.yml- Typo fixeng/pipelines/common/variables.yml- Typo fix