-
Notifications
You must be signed in to change notification settings - Fork 1.9k
Set the CV2 handlers as the default #33177
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR makes CollectionViewHandler2 and CarouselViewHandler2 the default handlers for iOS and MacCatalyst platforms in the test host app. When developers use CollectionView or CarouselView in tests, they will now get the V2 handlers by default instead of V1 handlers.
Key Changes
- Changed the default
cv2Handlersflag fromfalsetotruefor iOS/MacCatalyst test configuration - The environment variable override mechanism (
TEST_CONFIGURATION_ARGS) remains functional for tests that need to explicitly control handler versions
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
PureWeen
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we need to update the TEST_CONFIGURATION_ARGS setting as well in the yaml files
Can you make it so that CollectionView1 is now a separate test lane and CollectionView2 is the one that runs in the normal stage?
The changes on this Pr just make it so we are only testing CollectionView2
I have modified the TEST_CONFIGURATION_ARGS in the ui-test.yaml file so that CollectionView1/CarouselView1 run in a separate lane, and CollectionView2/CarouselView2 run in the main lane. Please let me know if you have any other concerns. @PureWeen |
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
|
/rebase |
53cbb9e to
9b6df10
Compare
Description of Change
To make CV2 handlers the default, set cv2handlers to true.
(i.e) when we use CollectionView / CarouselView = >
CollectionViewHandler2andCarouselViewHandler2are used by default.Explicitly setting CollectionView1/CarouselView1 or CollectionView2/CarouselView2 will configure the corresponding handlers correctly, as before.