Skip to content

Conversation

@Ahamed-Ali
Copy link
Contributor

Description of Change

To make CV2 handlers the default, set cv2handlers to true.

(i.e) when we use CollectionView / CarouselView = > CollectionViewHandler2 and CarouselViewHandler2 are used by default.

Explicitly setting CollectionView1/CarouselView1 or CollectionView2/CarouselView2 will configure the corresponding handlers correctly, as before.

@dotnet-policy-service dotnet-policy-service bot added the partner/syncfusion Issues / PR's with Syncfusion collaboration label Dec 16, 2025
@Ahamed-Ali Ahamed-Ali added area-testing Unit tests, device tests community ✨ Community Contribution labels Dec 16, 2025
@Ahamed-Ali Ahamed-Ali changed the title Make the Cv2 handlers default one Set the CV2 handlers as the default Dec 16, 2025
@sheiksyedm sheiksyedm marked this pull request as ready for review December 16, 2025 10:50
Copilot AI review requested due to automatic review settings December 16, 2025 10:50
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR makes CollectionViewHandler2 and CarouselViewHandler2 the default handlers for iOS and MacCatalyst platforms in the test host app. When developers use CollectionView or CarouselView in tests, they will now get the V2 handlers by default instead of V1 handlers.

Key Changes

  • Changed the default cv2Handlers flag from false to true for iOS/MacCatalyst test configuration
  • The environment variable override mechanism (TEST_CONFIGURATION_ARGS) remains functional for tests that need to explicitly control handler versions

@PureWeen
Copy link
Member

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 3 pipeline(s).

Copy link
Member

@PureWeen PureWeen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we need to update the TEST_CONFIGURATION_ARGS setting as well in the yaml files

Can you make it so that CollectionView1 is now a separate test lane and CollectionView2 is the one that runs in the normal stage?

The changes on this Pr just make it so we are only testing CollectionView2

@Ahamed-Ali
Copy link
Contributor Author

we need to update the TEST_CONFIGURATION_ARGS setting as well in the yaml files

Can you make it so that CollectionView1 is now a separate test lane and CollectionView2 is the one that runs in the normal stage?

The changes on this Pr just make it so we are only testing CollectionView2

I have modified the TEST_CONFIGURATION_ARGS in the ui-test.yaml file so that CollectionView1/CarouselView1 run in a separate lane, and CollectionView2/CarouselView2 run in the main lane. Please let me know if you have any other concerns. @PureWeen

@PureWeen
Copy link
Member

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@sheiksyedm
Copy link
Contributor

/rebase

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area-testing Unit tests, device tests community ✨ Community Contribution partner/syncfusion Issues / PR's with Syncfusion collaboration

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants