[ci] Update arcade on main #33100
[ci] Update arcade on main #33100
Conversation
|
🚀 Dogfood this PR with:
curl -fsSL https://raw.githubusercontent.com/dotnet/maui/main/eng/scripts/get-maui-pr.sh | bash -s -- 33100Or
iex "& { $(irm https://raw.githubusercontent.com/dotnet/maui/main/eng/scripts/get-maui-pr.ps1) } 33100" |
There was a problem hiding this comment.
Pull request overview
This PR updates the Arcade SDK infrastructure on the main branch, primarily upgrading MSBuild tooling versions and modernizing CI/CD configurations.
Key changes:
- Updates MSBuild XCopy version from 17.13.0 to 18.0.0
- Upgrades Azure DevOps build pool images from VS2022 to VS2026 Preview Scout
- Adds .NET 8.0 SDK installation for Darc tooling compatibility
Reviewed changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| eng/common/tools.ps1 | Updates default XCopy MSBuild version to 18.0.0 |
| eng/common/sdk-task.ps1 | Updates xcopy-msbuild default version to 18.0.0 |
| eng/common/post-build/redact-logs.ps1 | Minor formatting fix (removed line break in parameter definition) |
| eng/common/core-templates/steps/source-build.yml | Adds proper quoting around token variable |
| eng/common/core-templates/steps/publish-logs.yml | Adds proper quoting around BinlogToolVersion parameter |
| eng/common/core-templates/steps/install-microbuild.yml | Refactors MicroBuild installation with parameterized output folder and adds global.json creation for non-Windows platforms |
| eng/common/core-templates/post-build/post-build.yml | Updates build pool images to VS2026 Preview Scout and adds .NET 8.0 SDK installation for Darc |
| eng/common/core-templates/job/source-index-stage1.yml | Updates build pool images to VS2026 Preview Scout and sets default condition to main branch only |
| eng/common/core-templates/job/publish-build-assets.yml | Reorganizes parameters, adds .NET 8.0 SDK installation for Darc, and conditionalizes internal sources template |
| cat << 'EOF' > ${{ parameters.microBuildOutputFolder }}/global.json | ||
| { | ||
| "sdk": { | ||
| "version": "$version", | ||
| "paths": [ | ||
| "${{ parameters.microBuildOutputFolder }}/.dotnet-microbuild" | ||
| ], | ||
| "errorMessage": "The .NET SDK version $version is required to install the MicroBuild signing plugin." | ||
| } | ||
| } | ||
| EOF |
There was a problem hiding this comment.
The shell variable $version on lines 39 and 43 will not be expanded within single-quoted heredoc ('EOF'). Change to double-quoted heredoc ("EOF") or use unquoted EOF to enable variable substitution.
| - template: /eng/common/templates/steps/enable-internal-sources.yml | ||
| parameters: | ||
| legacyCredential: $(dn-bot-dnceng-artifact-feeds-rw) | ||
| ${{ if eq(variables['System.TeamProject'], 'DevDiv') }}: |
There was a problem hiding this comment.
The indentation of the conditional ${{ if eq(variables['System.TeamProject'], 'DevDiv') }}: appears incorrect. The parameters: block should be at the same level as the template path, but the conditional is one level above it. This creates ambiguity about whether the condition applies to the entire template call or just the parameters.
| - template: /eng/common/templates/steps/enable-internal-sources.yml | |
| parameters: | |
| legacyCredential: $(dn-bot-dnceng-artifact-feeds-rw) | |
| ${{ if eq(variables['System.TeamProject'], 'DevDiv') }}: | |
| - ${{ if eq(variables['System.TeamProject'], 'DevDiv') }}: | |
| template: /eng/common/templates/steps/enable-internal-sources.yml |
Description of Change
Update arcade sdk on main