Skip to content

Conversation

@PureWeen
Copy link
Member

@PureWeen PureWeen commented Dec 8, 2025

No description provided.

Copilot AI review requested due to automatic review settings December 8, 2025 20:47
@github-actions
Copy link
Contributor

github-actions bot commented Dec 8, 2025

🚀 Dogfood this PR with:

⚠️ WARNING: Do not do this without first carefully reviewing the code of this PR to satisfy yourself it is safe.

curl -fsSL https://raw.githubusercontent.com/dotnet/maui/main/eng/scripts/get-maui-pr.sh | bash -s -- 33061

Or

  • Run remotely in PowerShell:
iex "& { $(irm https://raw.githubusercontent.com/dotnet/maui/main/eng/scripts/get-maui-pr.ps1) } 33061"

@PureWeen
Copy link
Member Author

PureWeen commented Dec 8, 2025

/backport release/10.0.1xx-sr2

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR converts two XAML unit test files from NUnit to XUnit, aligning them with the current testing framework standard used throughout the Controls.Xaml.UnitTests project.

Key Changes

  • Converted test framework attributes from NUnit to XUnit syntax ([TestFixture][Collection("Issue")], [Test][Theory], [Values][XamlInflatorData])
  • Replaced NUnit-style assertions with XUnit equivalents (Assert.That()Assert.Equal()/Assert.NotNull()/Assert.True())
  • Updated lifecycle methods from NUnit to XUnit patterns ([SetUp]/[TearDown] → Constructor/IDisposable)

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
src/Controls/tests/Xaml.UnitTests/Issues/Maui28711.xaml.cs Converted test for verifying x:Name on SolidColorBrush resources; changed from NUnit to XUnit with proper assertion syntax
src/Controls/tests/Xaml.UnitTests/Issues/Maui27202.xaml.cs Converted test for derived styles inheriting VisualStateManager; migrated setup/teardown to constructor/IDisposable pattern and updated assertions to XUnit

@PureWeen
Copy link
Member Author

PureWeen commented Dec 8, 2025

/backport to release/10.0.1xx-sr2

@github-actions
Copy link
Contributor

github-actions bot commented Dec 8, 2025

Started backporting to release/10.0.1xx-sr2 (link to workflow run)

@PureWeen
Copy link
Member Author

PureWeen commented Dec 8, 2025

  • merging to fix main

@PureWeen PureWeen merged commit d2e5dfa into main Dec 8, 2025
18 of 70 checks passed
@PureWeen PureWeen deleted the fix/xaml-unittest-nunit-to-xunit branch December 8, 2025 22:06
PureWeen added a commit that referenced this pull request Dec 8, 2025
@PureWeen PureWeen added the area-testing Unit tests, device tests label Dec 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area-testing Unit tests, device tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants