-
Notifications
You must be signed in to change notification settings - Fork 1.9k
Convert Maui27202 and Maui28711 tests from NUnit to XUnit #33061
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
🚀 Dogfood this PR with:
curl -fsSL https://raw.githubusercontent.com/dotnet/maui/main/eng/scripts/get-maui-pr.sh | bash -s -- 33061Or
iex "& { $(irm https://raw.githubusercontent.com/dotnet/maui/main/eng/scripts/get-maui-pr.ps1) } 33061" |
|
/backport release/10.0.1xx-sr2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR converts two XAML unit test files from NUnit to XUnit, aligning them with the current testing framework standard used throughout the Controls.Xaml.UnitTests project.
Key Changes
- Converted test framework attributes from NUnit to XUnit syntax (
[TestFixture]→[Collection("Issue")],[Test]→[Theory],[Values]→[XamlInflatorData]) - Replaced NUnit-style assertions with XUnit equivalents (
Assert.That()→Assert.Equal()/Assert.NotNull()/Assert.True()) - Updated lifecycle methods from NUnit to XUnit patterns (
[SetUp]/[TearDown]→ Constructor/IDisposable)
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/Controls/tests/Xaml.UnitTests/Issues/Maui28711.xaml.cs | Converted test for verifying x:Name on SolidColorBrush resources; changed from NUnit to XUnit with proper assertion syntax |
| src/Controls/tests/Xaml.UnitTests/Issues/Maui27202.xaml.cs | Converted test for derived styles inheriting VisualStateManager; migrated setup/teardown to constructor/IDisposable pattern and updated assertions to XUnit |
|
/backport to release/10.0.1xx-sr2 |
|
Started backporting to |
|
No description provided.