-
Notifications
You must be signed in to change notification settings - Fork 1.9k
Add PR dogfooding script + automatic comment #33043
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR introduces automated dogfooding infrastructure to help community members test PR builds before they're merged. The automation adds instructional comments to PRs, and provides comprehensive scripts for applying PR artifacts to local projects.
Key Changes
- Automated GitHub Actions workflow that posts dogfooding instructions on every PR
- Cross-platform scripts (Bash and PowerShell) for downloading and applying PR NuGet packages
- Comprehensive documentation explaining usage, requirements, and troubleshooting
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 7 comments.
Show a summary per file
| File | Description |
|---|---|
.github/workflows/dogfood-comment.yml |
New workflow that automatically posts/updates dogfooding instructions on PRs |
eng/scripts/get-maui-pr.sh |
Bash script for Unix systems to download and apply PR artifacts |
eng/scripts/get-maui-pr.ps1 |
PowerShell script for cross-platform PR artifact application |
eng/scripts/README.md |
Documentation for the dogfooding scripts with usage examples and troubleshooting |
.github/PULL_REQUEST_TEMPLATE.md |
Removes manual dogfooding note (now automated by workflow) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 12 out of 12 changed files in this pull request and generated 4 comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 12 out of 12 changed files in this pull request and generated 1 comment.
| Write-Host "⚠️ $Message" -ForegroundColor Yellow | ||
| } | ||
|
|
||
| function Write-Error { |
Copilot
AI
Dec 8, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Write-Error is a built-in PowerShell cmdlet and should not be redefined. This function shadows the built-in cmdlet, which could cause confusion and unexpected behavior. Consider renaming this function to Write-ErrorMessage or similar to avoid conflicts.
| function Write-Error { | |
| function Write-ErrorMessage { |
This pull request introduces an automated workflow to add dogfooding instructions to pull requests, and provides comprehensive documentation for scripts that help users test PR builds locally. It also cleans up the PR template by removing a manual note about testing artifacts.
Dogfooding automation:
.github/workflows/dogfood-comment.yml) that automatically comments on PRs with instructions for testing the PR's build artifacts, updating the comment if one already exists. This workflow is triggered on PR events and can also be run manually.Documentation improvements:
README.mdineng/scriptsexplaining how to use theget-maui-pr.shandget-maui-pr.ps1scripts to fetch and apply PR NuGet artifacts, including usage examples, requirements, safety features, troubleshooting, and revert instructions.Template cleanup:
.github/PULL_REQUEST_TEMPLATE.md) that previously asked users to test PR artifacts and report results, as this is now automated.