Skip to content

Conversation

@jfversluis
Copy link
Member

This pull request introduces an automated workflow to add dogfooding instructions to pull requests, and provides comprehensive documentation for scripts that help users test PR builds locally. It also cleans up the PR template by removing a manual note about testing artifacts.

Dogfooding automation:

  • Added a new GitHub Actions workflow (.github/workflows/dogfood-comment.yml) that automatically comments on PRs with instructions for testing the PR's build artifacts, updating the comment if one already exists. This workflow is triggered on PR events and can also be run manually.

Documentation improvements:

  • Added a detailed README.md in eng/scripts explaining how to use the get-maui-pr.sh and get-maui-pr.ps1 scripts to fetch and apply PR NuGet artifacts, including usage examples, requirements, safety features, troubleshooting, and revert instructions.

Template cleanup:

  • Removed a manual note from the PR template (.github/PULL_REQUEST_TEMPLATE.md) that previously asked users to test PR artifacts and report results, as this is now automated.

Copilot AI review requested due to automatic review settings December 8, 2025 12:48
@jfversluis jfversluis added the area-infrastructure CI, Maestro / Coherency, upstream dependencies/versions label Dec 8, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR introduces automated dogfooding infrastructure to help community members test PR builds before they're merged. The automation adds instructional comments to PRs, and provides comprehensive scripts for applying PR artifacts to local projects.

Key Changes

  • Automated GitHub Actions workflow that posts dogfooding instructions on every PR
  • Cross-platform scripts (Bash and PowerShell) for downloading and applying PR NuGet packages
  • Comprehensive documentation explaining usage, requirements, and troubleshooting

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 7 comments.

Show a summary per file
File Description
.github/workflows/dogfood-comment.yml New workflow that automatically posts/updates dogfooding instructions on PRs
eng/scripts/get-maui-pr.sh Bash script for Unix systems to download and apply PR artifacts
eng/scripts/get-maui-pr.ps1 PowerShell script for cross-platform PR artifact application
eng/scripts/README.md Documentation for the dogfooding scripts with usage examples and troubleshooting
.github/PULL_REQUEST_TEMPLATE.md Removes manual dogfooding note (now automated by workflow)

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 12 out of 12 changed files in this pull request and generated 4 comments.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 12 out of 12 changed files in this pull request and generated 1 comment.

Write-Host "⚠️ $Message" -ForegroundColor Yellow
}

function Write-Error {
Copy link

Copilot AI Dec 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Write-Error is a built-in PowerShell cmdlet and should not be redefined. This function shadows the built-in cmdlet, which could cause confusion and unexpected behavior. Consider renaming this function to Write-ErrorMessage or similar to avoid conflicts.

Suggested change
function Write-Error {
function Write-ErrorMessage {

Copilot uses AI. Check for mistakes.
@jfversluis jfversluis merged commit d26a1d6 into main Dec 8, 2025
8 of 46 checks passed
@jfversluis jfversluis deleted the get-maui-pr branch December 8, 2025 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area-infrastructure CI, Maestro / Coherency, upstream dependencies/versions

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants