Skip to content

Conversation

@NirmalKumarYuvaraj
Copy link
Contributor

Note

Are you waiting for the changes in this PR to be merged?
It would be very helpful if you could test the resulting artifacts from this PR and let us know in a comment if this change resolves your issue. Thank you!

Description of Change

This pull request makes a minor update to the UpdateFlyoutFooter method in ShellFlyoutTemplatedContentRenderer.cs. Now, when the FlyoutFooter is null, the method also calls UpdateContentPadding() before returning. This ensures that the content padding is updated even when there is no footer present.

  • Call UpdateContentPadding() when FlyoutFooter is null in the UpdateFlyoutFooter method of ShellFlyoutTemplatedContentRenderer.cs to ensure correct padding.

Issues Fixed

Fixes #32883

Output

Before After
Before.mov
After.mov

@dotnet-policy-service dotnet-policy-service bot added the partner/syncfusion Issues / PR's with Syncfusion collaboration label Nov 27, 2025
@Tamilarasan-Paranthaman Tamilarasan-Paranthaman changed the title Fixed [Android] ShellFlyout Footer area not cleared after removing footer view [Android] Fixed ShellFlyout Footer area not cleared after removing footer view Nov 28, 2025
@sheiksyedm sheiksyedm marked this pull request as ready for review November 28, 2025 13:04
Copilot AI review requested due to automatic review settings November 28, 2025 13:04
@sheiksyedm
Copy link
Contributor

/azp run MAUI-UITests-public

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes a bug where the ShellFlyout footer area on Android was not properly cleared when the footer view was removed. The fix ensures that content padding is updated even when FlyoutFooter is set to null, allowing the flyout content to properly reclaim the space previously occupied by the footer.

Key changes:

  • Added UpdateContentPadding() call before returning when FlyoutFooter is null in the UpdateFlyoutFooter method

@PureWeen PureWeen added this to the .NET 10.0 SR2 milestone Dec 2, 2025
@PureWeen PureWeen moved this from Todo to In Progress in MAUI SDK Ongoing Dec 2, 2025
@sheiksyedm sheiksyedm added the community ✨ Community Contribution label Dec 3, 2025
@PureWeen PureWeen added the p/0 Current heighest priority issues that we are targeting for a release. label Dec 3, 2025
@PureWeen
Copy link
Member

PureWeen commented Dec 4, 2025

/rebase

Copy link
Member

@PureWeen PureWeen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've tested this locally and it works great. We'll get a UItest added in a follow up PR

@github-project-automation github-project-automation bot moved this from In Progress to Approved in MAUI SDK Ongoing Dec 5, 2025
@PureWeen PureWeen merged commit 53fdca5 into dotnet:main Dec 5, 2025
163 checks passed
@github-project-automation github-project-automation bot moved this from Approved to Done in MAUI SDK Ongoing Dec 5, 2025
@PureWeen PureWeen added area-safearea Issues/PRs that have to do with the SafeArea functionality and removed area-safearea Issues/PRs that have to do with the SafeArea functionality labels Dec 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area-controls-shell Shell Navigation, Routes, Tabs, Flyout community ✨ Community Contribution p/0 Current heighest priority issues that we are targeting for a release. partner/syncfusion Issues / PR's with Syncfusion collaboration platform/android shell-flyout

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

[Android] ShellFlyout Footer area not cleared after removing footer view

4 participants