-
Notifications
You must be signed in to change notification settings - Fork 1.9k
[Android] Fixed ShellFlyout Footer area not cleared after removing footer view #32884
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
/azp run MAUI-UITests-public |
|
Azure Pipelines successfully started running 1 pipeline(s). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR fixes a bug where the ShellFlyout footer area on Android was not properly cleared when the footer view was removed. The fix ensures that content padding is updated even when FlyoutFooter is set to null, allowing the flyout content to properly reclaim the space previously occupied by the footer.
Key changes:
- Added
UpdateContentPadding()call before returning whenFlyoutFooterisnullin theUpdateFlyoutFootermethod
|
/rebase |
c4fe84d to
3971935
Compare
PureWeen
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've tested this locally and it works great. We'll get a UItest added in a follow up PR
Note
Are you waiting for the changes in this PR to be merged?
It would be very helpful if you could test the resulting artifacts from this PR and let us know in a comment if this change resolves your issue. Thank you!
Description of Change
This pull request makes a minor update to the
UpdateFlyoutFootermethod inShellFlyoutTemplatedContentRenderer.cs. Now, when theFlyoutFooterisnull, the method also callsUpdateContentPadding()before returning. This ensures that the content padding is updated even when there is no footer present.UpdateContentPadding()whenFlyoutFooterisnullin theUpdateFlyoutFootermethod ofShellFlyoutTemplatedContentRenderer.csto ensure correct padding.Issues Fixed
Fixes #32883
Output
Before.mov
After.mov