-
Notifications
You must be signed in to change notification settings - Fork 1.9k
[iOS] Fix for Shell Navigation Bar Remaining Visible After Navigating Back to a ContentPage with NavigationBar Hidden #32622
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[iOS] Fix for Shell Navigation Bar Remaining Visible After Navigating Back to a ContentPage with NavigationBar Hidden #32622
Conversation
… Back to a ContentPage with NavigationBar Hidden
|
Hey there @@SyedAbdulAzeemSF4852! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed. |
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This pull request fixes an iOS-specific Shell navigation bar visibility bug where navigating back to a ContentPage with a hidden navigation bar would incorrectly show the navigation bar. The issue was introduced in PR #29279.
Key Changes
- Core Fix: Added a call to
SetNavigationBarHiddenin theWillShowViewControllermethod to apply the calculated navigation bar visibility state during iOS navigation transitions - Test Coverage: Added comprehensive UI tests with screenshot verification for iOS and Android platforms
- Test Implementation: Created test pages demonstrating the issue scenario (main page with hidden nav bar → message page with visible nav bar → back to main page)
Reviewed Changes
Copilot reviewed 3 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| ShellSectionRenderer.cs | Added SetNavigationBarHidden call in WillShowViewController to apply nav bar visibility during transitions with proper animation support |
| Issue32583.cs (HostApp) | Test page implementation with main page (hidden nav bar) and message page (visible nav bar) to reproduce the issue |
| Issue32583.cs (Tests) | UI test that navigates forward and back, then verifies with screenshot that nav bar remains hidden |
| NavigationBarShouldRemainHiddenAfterNavigatingBack.png (iOS) | Baseline screenshot for iOS test verification |
| NavigationBarShouldRemainHiddenAfterNavigatingBack.png (Android) | Baseline screenshot for Android test verification |
… Back to a ContentPage with NavigationBar Hidden (#32622) * [iOS] Fix for Shell Navigation Bar Remaining Visible After Navigating Back to a ContentPage with NavigationBar Hidden * Added test cases and snapshots for both iOS and Android platforms * Added snapshot for windows platform
… Back to a ContentPage with NavigationBar Hidden (#32622) * [iOS] Fix for Shell Navigation Bar Remaining Visible After Navigating Back to a ContentPage with NavigationBar Hidden * Added test cases and snapshots for both iOS and Android platforms * Added snapshot for windows platform
… Back to a ContentPage with NavigationBar Hidden (#32622) * [iOS] Fix for Shell Navigation Bar Remaining Visible After Navigating Back to a ContentPage with NavigationBar Hidden * Added test cases and snapshots for both iOS and Android platforms * Added snapshot for windows platform
… Back to a ContentPage with NavigationBar Hidden (#32622) * [iOS] Fix for Shell Navigation Bar Remaining Visible After Navigating Back to a ContentPage with NavigationBar Hidden * Added test cases and snapshots for both iOS and Android platforms * Added snapshot for windows platform
… Back to a ContentPage with NavigationBar Hidden (#32622) * [iOS] Fix for Shell Navigation Bar Remaining Visible After Navigating Back to a ContentPage with NavigationBar Hidden * Added test cases and snapshots for both iOS and Android platforms * Added snapshot for windows platform
Note
Are you waiting for the changes in this PR to be merged?
It would be very helpful if you could test the resulting artifacts from this PR and let us know in a comment if this change resolves your issue. Thank you!
Issue Details
Break/Regression Information
Root Cause
Description of Change
Issues Fixed
Fixes #32583
Validated the behaviour in the following platforms
Output
Before.mov
After.mov