Skip to content

Conversation

Copy link
Contributor

Copilot AI commented Nov 10, 2025

Note

Are you waiting for the changes in this PR to be merged?
It would be very helpful if you could test the resulting artifacts from this PR and let us know in a comment if this change resolves your issue. Thank you!

Description of Change

This PR consolidates and improves AI agent documentation and testing instructions for the .NET MAUI repository. It includes comprehensive improvements to testing workflows, instruction organization, and new guidance documents.

Major Changes

1. New Instruction Files

📄 .github/instructions/appium-control.instructions.md (369 lines)

  • Complete guide for creating standalone Appium control scripts
  • Manual debugging and exploration workflows
  • Platform-specific configuration (iOS/Android)
  • Interactive testing patterns
  • Troubleshooting section

📄 .github/instructions/common-testing-patterns.md (397 lines)

  • Consolidates recurring command patterns used across multiple instruction files
  • UDID extraction patterns for iOS (default and version-specific) and Android
  • Device boot and verification patterns
  • Build commands with error checking
  • App deployment patterns
  • Reduces duplication across instruction files

2. Enhanced Existing Instructions

.github/agents/pr-reviewer.md (+98 lines)

.github/instructions/uitests.instructions.md (+118 lines)

  • Cross-references to common testing patterns
  • Improved UDID extraction guidance
  • Enhanced iOS version selection logic
  • Better device targeting documentation
  • Appium startup troubleshooting

.github/instructions/instrumentation.instructions.md (+47 lines)

  • References common testing patterns
  • Improved command examples
  • Better integration with testing workflow

.github/copilot-instructions.md (+32 lines)

  • Added cross-references to new instruction files
  • Updated related documentation section
  • Improved navigation between guides

3. Repository Organization

Removed: AGENTS.md (-521 lines)

  • Content has been moved and reorganized into .github/instructions/ directory
  • Better organization with focused, single-purpose instruction files

Updated: .github/README-AI.md (+2 lines)

  • Links to new instruction files

Updated: .gitignore (+1 line)

  • Added pattern for SandboxAppium directory (used in Appium control scripts)

4. Documentation Updates

docs/UITesting-Guide.md (+8 lines)

  • Updated to reference new instruction structure
  • Cross-links to agent instructions

docs/PR-Test-Validation-Guide.md (+5 lines)

  • Updated references to new instruction locations

5. Sample Code Updates

src/Controls/samples/Controls.Sample.Sandbox/Platforms/Android/MainActivity.cs (+2 lines)

  • Added SoftInputMode configuration for better keyboard testing

Statistics

  • Files changed: 12
  • Additions: 1,034 lines
  • Deletions: 566 lines
  • Net change: +468 lines (improved organization and documentation)

Benefits

Better organization - Focused instruction files instead of monolithic documents
Reduced duplication - Common patterns extracted to reusable reference document
Improved discoverability - Cross-references between related instructions
Enhanced testing workflows - Comprehensive Appium and testing guidance
Easier maintenance - Single source of truth for common patterns
Better agent guidance - Clearer, more actionable instructions

Issues Fixed

N/A - Documentation and instruction improvements

Includes pr-reviewer.md updates from PR #32405

Original prompt

Create a PR that's just the pr-reviewer.md updates from this PR
#32405


💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

Copilot AI changed the title [WIP] Update pr-reviewer.md with recent changes Extract pr-reviewer.md updates from PR #32405 Nov 10, 2025
Copilot AI requested a review from PureWeen November 10, 2025 20:48
@PureWeen PureWeen marked this pull request as ready for review November 10, 2025 20:48
Copilot AI review requested due to automatic review settings November 10, 2025 20:48
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR extracts documentation improvements for the PR review workflow from PR #32405, specifically updating .github/agents/pr-reviewer.md to introduce dynamic branch tracking instead of hardcoded branch references.

Key changes:

  • Introduces ORIGINAL_BRANCH variable to capture and preserve the reviewer's starting branch context
  • Updates all cleanup sections to use this variable for reliable return to starting state
  • Improves clarity with fallback instructions when the variable isn't available

@PureWeen PureWeen force-pushed the copilot/update-pr-reviewer-md branch from 91a607a to ffe8f71 Compare November 12, 2025 21:10
@PureWeen
Copy link
Member

@copilot can you update the description on this PR to represent all the changes that have been made on this PR?
#32485

Copy link
Contributor Author

Copilot AI commented Nov 12, 2025

@copilot can you update the description on this PR to represent all the changes that have been made on this PR?
#32485

Updated the PR description to reflect all changes made across the 6 commits. The PR has evolved significantly beyond the original pr-reviewer.md updates to include:

  • 2 new instruction files (appium-control and common-testing-patterns)
  • Enhancements to existing instructions (pr-reviewer, uitests, instrumentation, copilot-instructions)
  • Reorganization (removed AGENTS.md, moved content to .github/instructions/)
  • Documentation updates and cross-references

Total: 1,034 additions, 566 deletions across 12 files.

Copilot AI changed the title Extract pr-reviewer.md updates from PR #32405 Improve AI agent documentation and testing instructions Nov 12, 2025
@PureWeen PureWeen force-pushed the copilot/update-pr-reviewer-md branch from ffe8f71 to 6d7d825 Compare November 12, 2025 22:36
@PureWeen
Copy link
Member

/azp run MAUI-public

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@PureWeen PureWeen merged commit fec9816 into main Nov 12, 2025
4 of 18 checks passed
@PureWeen PureWeen deleted the copilot/update-pr-reviewer-md branch November 12, 2025 23:28
@github-actions github-actions bot locked and limited conversation to collaborators Dec 13, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants